r28 | charles.nicholson | 2010-07-29 17:43:45 -0500 (Thu, 29 Jul 2010) | 1 line

pjohnmeyer · pjohnmeyer · commit 57bf80682e17 · 2013-01-09T23:45:25.000-06:00
fix strict aliasing violation, was causing gcc failures.  use std::memcpy instead of union-cast
diff --git a/src/tests/TestChecks.cpp b/src/tests/TestChecks.cpp
@@ -1,6 +1,8 @@
 #include "../../unittestpp.h"
 #include "RecordingReporter.h"
 
+#include <cstring>
+
 using namespace UnitTest;
 
 
@@ -119,25 +121,21 @@ TEST(CheckCloseWithZeroEpsilonWorksForSameNumber)
 
 TEST(CheckCloseWithNaNFails)
 {
-    union
-    {
-        unsigned int bitpattern;
-        float nan;
-    };
-    bitpattern = 0xFFFFFFFF;
-    TestResults results;
+	const unsigned int bitpattern = 0xFFFFFFFF;
+	float nan;
+	std::memcpy(&nan, &bitpattern, sizeof(bitpattern));
+
+	TestResults results;
     CheckClose(results, 3.0f, nan, 0.1f, TestDetails("", "", "", 0));
     CHECK_EQUAL(1, results.GetFailureCount());
 }
 
 TEST(CheckCloseWithNaNAgainstItselfFails)
 {
-    union
-    {
-        unsigned int bitpattern;
-        float nan;
-    };
-    bitpattern = 0xFFFFFFFF;
+	const unsigned int bitpattern = 0xFFFFFFFF;
+	float nan;
+	std::memcpy(&nan, &bitpattern, sizeof(bitpattern));
+
     TestResults results;
     CheckClose(results, nan, nan, 0.1f, TestDetails("", "", "", 0));
     CHECK_EQUAL(1, results.GetFailureCount());
