Merge pull request #120 from pjohnmeyer/check_by_reference

pjohnmeyer · web-flow · commit 77ae15ab8acd · 2016-08-16T22:22:58.000-05:00
Take UnitTest::Check parameter by const reference
diff --git a/UnitTest++/Checks.h b/UnitTest++/Checks.h
@@ -9,7 +9,7 @@ namespace UnitTest {
 
 
    template< typename Value >
-   bool Check(Value const value)
+   bool Check(Value const& value)
    {
       return !!value; // doing double negative to avoid silly VS warnings
    }
diff --git a/tests/TestChecks.cpp b/tests/TestChecks.cpp
@@ -315,4 +315,32 @@ namespace {
       CHECK_EQUAL(1234, reporter.lastFailedLine);
    }
 
+   class TruthyUnlessCopied
+   {
+   public:
+      TruthyUnlessCopied()
+      : truthy_(true)
+      {
+      }
+
+      TruthyUnlessCopied(const TruthyUnlessCopied&)
+      : truthy_(false)
+      {
+      }
+
+      operator bool() const
+      {
+         return truthy_;
+      }
+
+   private:
+      bool truthy_;
+   };
+
+   TEST(CheckProperlyDealsWithOperatorBoolOverrides)
+   {
+      TruthyUnlessCopied objectThatShouldBeTruthy;
+      CHECK(objectThatShouldBeTruthy);
+   }
+
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ namespace UnitTest {`
`9`	`9`
`10`	`10`
`11`	`11`	`template< typename Value >`
`12`		`- bool Check(Value const value)`
	`12`	`+ bool Check(Value const& value)`
`13`	`13`	`{`
`14`	`14`	`return !!value; // doing double negative to avoid silly VS warnings`
`15`	`15`	`}`