less GC in GetSRP(), search filter: use ordinalignorecase,

unitycoder · unitycoder · commit 50804045d215 · 2025-05-28T14:58:55.000+03:00
diff --git a/UnityLauncherPro/MainWindow.xaml.cs b/UnityLauncherPro/MainWindow.xaml.cs
@@ -439,16 +439,16 @@ private bool ProjectFilter(object item)
                 bool found = true;
                 foreach (var word in searchWords)
                 {
-                    bool titleMatched = proj.Title.IndexOf(word, 0, StringComparison.CurrentCultureIgnoreCase) != -1;
-                    bool pathMatched = searchProjectPathAlso && proj.Path.IndexOf(word, 0, StringComparison.CurrentCultureIgnoreCase) != -1;
+                    bool titleMatched = proj.Title.IndexOf(word, 0, StringComparison.OrdinalIgnoreCase) != -1;
+                    bool pathMatched = searchProjectPathAlso && proj.Path.IndexOf(word, 0, StringComparison.OrdinalIgnoreCase) != -1;
                     found = found && (titleMatched || pathMatched);
                 }
                 return found;
             }
             else // single word search
             {
-                bool titleMatched = proj.Title.IndexOf(_filterString, 0, StringComparison.CurrentCultureIgnoreCase) != -1;
-                bool pathMatched = searchProjectPathAlso && proj.Path.IndexOf(_filterString, 0, StringComparison.CurrentCultureIgnoreCase) != -1;
+                bool titleMatched = proj.Title.IndexOf(_filterString, 0, StringComparison.OrdinalIgnoreCase) != -1;
+                bool pathMatched = searchProjectPathAlso && proj.Path.IndexOf(_filterString, 0, StringComparison.OrdinalIgnoreCase) != -1;
 
                 return titleMatched || pathMatched;
             }
diff --git a/UnityLauncherPro/Properties/AssemblyInfo.cs b/UnityLauncherPro/Properties/AssemblyInfo.cs
@@ -12,7 +12,7 @@
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("UnityCoder.com")]
 [assembly: AssemblyProduct("UnityLauncherPro")]
-[assembly: AssemblyCopyright("Copyright © 2023")]
+[assembly: AssemblyCopyright("Copyright © 2025")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
diff --git a/UnityLauncherPro/Tools.cs b/UnityLauncherPro/Tools.cs
@@ -2603,34 +2603,36 @@ private static async Task<bool> DownloadFileAsync(string fileUrl, string destina
 
         internal static string GetSRP(string projectPath)
         {
-            // read projectsettings/graphicsettings file, look for m_SRPDefaultSettings: value
             var settingsFile = Path.Combine(projectPath, "ProjectSettings", "GraphicsSettings.asset");
-            if (File.Exists(settingsFile) == false) return null;
+            if (!File.Exists(settingsFile)) return null;
 
-            var allText = File.ReadAllText(settingsFile);
-            var srpIndex = allText.IndexOf("m_SRPDefaultSettings:");
-            if (srpIndex == -1)
-            {
-                srpIndex = allText.IndexOf("m_RenderPipelineGlobalSettingsMap:"); // unity 6000.2- ?
-                if (srpIndex == -1) return null; // BIRP
-            }
-
-            // urp = UnityEngine.Rendering.Universal.UniversalRenderPipeline
-            // hdrp = UnityEngine.Rendering.HighDefinition.HDRenderPipeline
+            bool srpSectionFound = false;
 
-            if (allText.IndexOf("UnityEngine.Rendering.Universal.UniversalRenderPipeline", srpIndex) > -1)
-            {
-                return "URP";
-            }
-            else if (allText.IndexOf("UnityEngine.Rendering.HighDefinition.HDRenderPipeline", srpIndex) > -1)
+            using (var reader = new StreamReader(settingsFile))
             {
-                return "HDRP";
-            }
-            else
-            {
-                return null; // BIRP
-            }
+                string line;
+                while ((line = reader.ReadLine()) != null)
+                {
+                    if (!srpSectionFound)
+                    {
+                        if (line.Contains("m_SRPDefaultSettings:") || line.Contains("m_RenderPipelineGlobalSettingsMap:"))
+                        {
+                            srpSectionFound = true;
+                        }
+                        continue;
+                    }
 
+                    if (line.Contains("UniversalRenderPipeline"))
+                    {
+                        return "URP";
+                    }
+                    else if (line.Contains("HDRenderPipeline"))
+                    {
+                        return "HDRP";
+                    }
+                }
+            }
+            return null; // BIRP or unknown
         }
 
         internal static void InstallAPK(string ApkPath)

Original file line number	Diff line number	Diff line change
`@@ -439,16 +439,16 @@ private bool ProjectFilter(object item)`
`439`	`439`	`bool found = true;`
`440`	`440`	`foreach (var word in searchWords)`
`441`	`441`	`{`
`442`		`- bool titleMatched = proj.Title.IndexOf(word, 0, StringComparison.CurrentCultureIgnoreCase) != -1;`
`443`		`- bool pathMatched = searchProjectPathAlso && proj.Path.IndexOf(word, 0, StringComparison.CurrentCultureIgnoreCase) != -1;`
	`442`	`+ bool titleMatched = proj.Title.IndexOf(word, 0, StringComparison.OrdinalIgnoreCase) != -1;`
	`443`	`+ bool pathMatched = searchProjectPathAlso && proj.Path.IndexOf(word, 0, StringComparison.OrdinalIgnoreCase) != -1;`
`444`	`444`	`found = found && (titleMatched \|\| pathMatched);`
`445`	`445`	`}`
`446`	`446`	`return found;`
`447`	`447`	`}`
`448`	`448`	`else // single word search`
`449`	`449`	`{`
`450`		`- bool titleMatched = proj.Title.IndexOf(_filterString, 0, StringComparison.CurrentCultureIgnoreCase) != -1;`
`451`		`- bool pathMatched = searchProjectPathAlso && proj.Path.IndexOf(_filterString, 0, StringComparison.CurrentCultureIgnoreCase) != -1;`
	`450`	`+ bool titleMatched = proj.Title.IndexOf(_filterString, 0, StringComparison.OrdinalIgnoreCase) != -1;`
	`451`	`+ bool pathMatched = searchProjectPathAlso && proj.Path.IndexOf(_filterString, 0, StringComparison.OrdinalIgnoreCase) != -1;`
`452`	`452`
`453`	`453`	`return titleMatched \|\| pathMatched;`
`454`	`454`	`}`