Skip to content

Exclude Unit Test packages from coverage #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2022
Merged

Exclude Unit Test packages from coverage #1226

merged 3 commits into from
Oct 17, 2022

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Aug 18, 2022

Resolves #1222

@jgebal jgebal added this to the 3.1.13 milestone Aug 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022 •
edited
Loading

Unit Test Results

       1 files  ±0         2 suites  ±0   5m 5s ⏱️ +30s
1 025 tests ±0  1 021 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
1 028 runs  ±0  1 020 ✔️ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit d825156. ± Comparison against base commit 519f06b.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 18, 2022 •
edited
Loading

Codecov Report

Base: 94.31% // Head: 94.45% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (d825156) compared to base (519f06b).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1226      +/-   ##
===========================================
+ Coverage    94.31%   94.45%   +0.14%     
===========================================
  Files          108      108              
  Lines         5085     5089       +4     
  Branches        22       22              
===========================================
+ Hits          4796     4807      +11     
+ Misses         281      274       -7     
  Partials         8        8
Flag Coverage Δ
11XE 93.79% <71.42%> (+0.04%) ⬆️
12.1EE 93.83% <71.42%> (+0.06%) ⬆️
18XE 94.11% <71.42%> (-0.02%) ⬇️
21XE 94.28% <71.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/core/coverage/ut_coverage.pkb 97.05% <0.00%> (ø)
source/core/ut_suite_manager.pkb 96.70% <83.33%> (-0.51%) ⬇️
...pectations/data_values/ut_compound_data_helper.pkb 98.68% <0.00%> (+0.44%) ⬆️
source/expectations/ut_expectation.tpb 98.74% <0.00%> (+0.62%) ⬆️
source/api/ut.pkb 93.26% <0.00%> (+0.96%) ⬆️
source/expectations/matchers/ut_equal.tpb 100.00% <0.00%> (+1.73%) ⬆️
...ce/expectations/data_values/ut_data_value_json.tpb 98.46% <0.00%> (+4.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jgebal jgebal force-pushed the bugfix/exclude_ut_packages_from_coverage branch 2 times, most recently from 7d897a8 to 03b84dc Compare September 7, 2022 10:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@jgebal jgebal force-pushed the bugfix/exclude_ut_packages_from_coverage branch from 03b84dc to 8ac32d7 Compare October 16, 2022 19:09
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@jgebal jgebal merged commit e4c9809 into develop Oct 17, 2022
@jgebal jgebal deleted the bugfix/exclude_ut_packages_from_coverage branch October 17, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.13
Development

Successfully merging this pull request may close these issues.

Code Coverage does not exclude Tests
1 participant
@jgebal