Skip to content

Bad/misleading failure message when comparing different datatypes #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgebal opened this issue May 30, 2017 · 0 comments
Closed

Bad/misleading failure message when comparing different datatypes #334

jgebal opened this issue May 30, 2017 · 0 comments
Assignees
@jgebal
Labels
bug enhancement
Milestone
v3.0.1

Comments

@jgebal
Copy link
Member

jgebal commented May 30, 2017 •
edited
Loading

Currently when comparing two different datatypes for equality we get something like below:

5) object_compare_different_type
      The matcher 'equal' cannot be used with data type (ut3.demo_department_new).
      at "UT3.DEMO_EQUAL_MATCHER", line 69 ut.expect(anydata.convertObject(l_actual)).to_equal(anydata.convertObject(l_expected));

You can see it on travis-ci build

This should be more of a message like:

      The matcher 'equal' cannot be used to compare datatypes (ut3.demo_department_new) and (ut3.demo_department).

The message is misleading and could make developer think that the matcher is not capable of evaluating the given datatype.
@jgebal jgebal added this to the v3.0.1 milestone May 31, 2017
@jgebal jgebal changed the title Bad/misleading failure message when comaring different datatypes Bad/misleading failure message when comparing different datatypes Jun 7, 2017
@jgebal jgebal mentioned this issue Jun 7, 2017
Merged
@jgebal jgebal self-assigned this Jun 7, 2017
@ghost ghost removed the in progress label Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgebal jgebal

Labels
bug enhancement
Projects
None yet
Milestone
v3.0.1
Development

No branches or pull requests
1 participant
@jgebal