Enable duplicate detection on cursor comparison using join by #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sure that we have same amount of rows when rows are identical but row counts is different.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1295 +/- ##
========================================
Coverage 94.97% 94.97%
========================================
Files 111 111
Lines 5396 5396
Branches 34 34
========================================
Hits 5125 5125
Misses 271 271
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Build is failing on 11 and 12 because procedure name is too long. |
|
People getting use to good things to quickly :) Updated |
jgebal
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1293
In certain scenarios when the data sets are identical but have an duplicate rows, the cursors join_by when doing join in SQL joined only by PK which resulted on full match from differences query.
Extended a PK join by to the duplicate number to make sure we match on the rows number.
Testing case was added however due to issue with a cursor comparison inside the logic the case will fail until merged into develop.