Skip to content

implemented timing reporting for documentation reporter #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2017

Conversation

Pazus
Copy link
Member

@Pazus Pazus commented Jun 27, 2017

Added timing reporting for documentation reporter (nonconditional).
addressed #351

@Pazus Pazus added this to the v3.0.2 milestone Jun 27, 2017
@Pazus Pazus self-assigned this Jun 27, 2017
@Pazus Pazus requested a review from jgebal June 27, 2017 19:17
@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage remained the same at 91.708% when pulling ea719b2 on Pazus:issue-351 into 65d0169 on utPLSQL:develop.

@jgebal
Copy link
Member

jgebal commented Jun 27, 2017

I wonder if reporter with timing should be a separate reporter (under ut_documentation_reporter).
The new reporter would only need to override the after_calling_test method.
Also, maybe use square brackets to make [.012 sec] more distinguishable from (FAILURE)

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage remained the same at 91.708% when pulling ea719b2 on Pazus:issue-351 into 65d0169 on utPLSQL:develop.

@Pazus
Copy link
Member Author

Pazus commented Jun 28, 2017

Do you think we need a separate one? At first I thought the same but then I realized that we go that we then we have to make a choice which reporter to use, and as its mostly used from ut.run we don't have a way to choose there. This means standard ut.run reporter has to be the most appropriate for the human-user (not CI). I think timing is a simple nice addition.

Like your idea about square brackets! Changing it.

@coveralls
Copy link

coveralls commented Jun 29, 2017

Coverage Status

Coverage increased (+0.2%) to 91.858% when pulling afa80a2 on Pazus:issue-351 into 021eead on utPLSQL:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.858% when pulling 16545e5 on Pazus:issue-351 into 021eead on utPLSQL:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.858% when pulling 16545e5 on Pazus:issue-351 into 021eead on utPLSQL:develop.

@coveralls
Copy link

coveralls commented Jul 1, 2017

Coverage Status

Coverage increased (+0.2%) to 91.858% when pulling c3c7a55 on Pazus:issue-351 into 021eead on utPLSQL:develop.

@coveralls
Copy link

coveralls commented Jul 1, 2017

Coverage Status

Coverage increased (+0.2%) to 91.858% when pulling c3c7a55 on Pazus:issue-351 into 021eead on utPLSQL:develop.

@jgebal jgebal merged commit e49f6df into utPLSQL:develop Jul 2, 2017
@jgebal jgebal removed the in progress label Jul 2, 2017
@Pazus Pazus deleted the issue-351 branch July 3, 2017 05:09
Pazus added a commit that referenced this pull request Jul 18, 2017
### Documentation
  #399 Documentation now refers to [migration](https://github.com/utPLSQL/utPLSQL-v2-v3-migration) project
  #386 Documentation now refers to a valid object name: `ut_file_mapping`
  #362 Install and Uninstall scripts are now much more readable
  #361 Install guide now provides snippet on how to download latest release on Windows

### Installation
  #396 Added override user/password/tablespace for install_headless
  #384 Installation is now smooth even if profiler tables already exist

### Internal improvements
  #388 Improved reporting from RunTest
  #363 Fixed publishing of release documentation history

### Improvements and fixes
  #407 Fixed rare issue with `ORA-22813: operand value exceeds system limits`
  #403 Stack trace is now properly parsed on all machines
  #397 The `--%disabled` annotation on suite level is now reporting all tests as disabled
  #395 Coverage reporting is now properly filtering test packages on that use suitepath
  #390 Line of code for failed expectation is now also shown for unit tests owned by other users
  #380 Line no of failed test is now properly reported when using `ut.fail`
  #375 Annotation parameter list can now have spaces before/after brackets
  #373 Warnings in documentation reporter are now properly numbered
  #372 Documentation reporter is now providing a timing information for each test
  #370 by xUnit reporter now displays name of the package/procedure if suite/test has no description
  #369 Fixed errors with multi-byte characters in conversion from/to clob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants