Fixed indexing of warnings for documentation reporter #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgebal
requested changes
Jun 27, 2017
| @@ -151,7 +153,8 @@ create or replace type body ut_documentation_reporter is | |||
|
|
|||
| if a_item.warnings is not null and a_item.warnings.count > 0 then | |||
| for i in 1 .. a_item.warnings.count loop | |||
| self.print_text(' ' || i || ') ' || a_item.path); | |||
| l_warning_index := l_warning_index + 1; | |||
| self.print_text(' ' || l_warning_index || ') ' || a_item.path); | |||
There was a problem hiding this comment.
Can you make both error_no and warning_no uniformly indented
lpad(l_warning_index,5)
I don't expect any report to have more than 9999 errors or warnings in it.
There was a problem hiding this comment.
Done. It is already done for errors, so I made it only for warnings
jgebal
approved these changes
Jun 29, 2017
jgebal
approved these changes
Jul 2, 2017
Pazus
added a commit
that referenced
this pull request
Jul 18, 2017
### Documentation #399 Documentation now refers to [migration](https://github.com/utPLSQL/utPLSQL-v2-v3-migration) project #386 Documentation now refers to a valid object name: `ut_file_mapping` #362 Install and Uninstall scripts are now much more readable #361 Install guide now provides snippet on how to download latest release on Windows ### Installation #396 Added override user/password/tablespace for install_headless #384 Installation is now smooth even if profiler tables already exist ### Internal improvements #388 Improved reporting from RunTest #363 Fixed publishing of release documentation history ### Improvements and fixes #407 Fixed rare issue with `ORA-22813: operand value exceeds system limits` #403 Stack trace is now properly parsed on all machines #397 The `--%disabled` annotation on suite level is now reporting all tests as disabled #395 Coverage reporting is now properly filtering test packages on that use suitepath #390 Line of code for failed expectation is now also shown for unit tests owned by other users #380 Line no of failed test is now properly reported when using `ut.fail` #375 Annotation parameter list can now have spaces before/after brackets #373 Warnings in documentation reporter are now properly numbered #372 Documentation reporter is now providing a timing information for each test #370 by xUnit reporter now displays name of the package/procedure if suite/test has no description #369 Fixed errors with multi-byte characters in conversion from/to clob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #350