Skip to content

Update issue with xml special chars in failure. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2018
Merged

Update issue with xml special chars in failure. #669

merged 1 commit into from
May 12, 2018

Conversation

lwasylow
Copy link
Member

Remove CDDATA and replace with xml convert
Text inside a CDDATA was not treated as xml so converting all characters was causing a poor display e.g.

Actual: 'test' (varchar2) was expected to equal: '<![CDATA[some stuff]]>' (varchar2)
"at "UT3.CHECK_FAIL_ESCAPE.FAIL_MISERABLY", line 4 ut3.ut.expect('test').to_equal('<![CDATA[some stuff]]>');

Converted all text using XML CONVERT and removing CDDATA allowed to generate proper result and escape CDDATA tags that caused failure of xml message.

Actual: 'test' (varchar2) was expected to equal: '<![CDATA[some stuff]]>' (varchar2)
"at "UT3.CHECK_FAIL_ESCAPE.FAIL_MISERABLY", line 4 ut3.ut.expect('test').to_equal('some stuff');"

XML content attached along with the screen from jenkins for that xml.
junit.txt

test_evidence

Remove CDDATA and replace with xml convert
@jgebal jgebal added this to the 3.1.2 milestone May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants