Skip to content

Fixed issue with sonar scanner failing on PR's from other repositories. #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 18, 2018
Merged

Fixed issue with sonar scanner failing on PR's from other repositories. #720

merged 7 commits into from
Jul 18, 2018

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Jul 16, 2018

No description provided.

@jgebal jgebal requested a review from lwasylow July 16, 2018 23:59
lwasylow
lwasylow reviewed Jul 17, 2018
View reviewed changes
Copy link
Member

@lwasylow lwasylow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that if not be inside if, as part of if Travis pull request - ne false and... ? The same code runs for pr and branch. If we run on branch then if condition for Travis pull repo will be empty?? That would stop branch running right?

lwasylow
lwasylow reviewed Jul 17, 2018
View reviewed changes
Copy link
Member

@lwasylow lwasylow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that if not be inside if, as part of if Travis pull request - ne false and... ? The same code runs for pr and branch. If we run on branch then if condition for Travis pull repo will be empty?? That would stop branch running right?

@jgebal
Copy link
Member Author

jgebal commented Jul 17, 2018

I think you're right.

@jgebal jgebal merged commit db969b6 into develop Jul 18, 2018
@jgebal jgebal deleted the feature/disable_sonar_pr_from_others branch July 18, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwasylow lwasylow lwasylow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgebal @lwasylow