Skip to content

Commit c3393b5

Browse files
PhilippSalvisbergPhilippSalvisberg
committed
adapt test cases to match new counter default values
1 parent 6d69770 commit c3393b5

File tree

1 file changed

+34
-20
lines changed

1 file changed

+34
-20
lines changed

‎sqldev/src/test/java/org/utplsql/sqldev/test/JsonToStringStylerTest.java

Lines changed: 34 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@
1515
*/
1616
package org.utplsql.sqldev.test;
1717

18-
import java.util.Arrays;
18+
import java.util.Collections;
1919

2020
import org.junit.Assert;
2121
import org.junit.Test;
2222
import org.utplsql.sqldev.model.runner.Run;
2323
import org.utplsql.sqldev.model.ut.OutputLines;
2424

25+
@SuppressWarnings("StringBufferReplaceableByString")
2526
public class JsonToStringStylerTest {
2627

2728
@Test
@@ -64,7 +65,7 @@ public void outputLinesWithoutLines() {
6465

6566
@Test
6667
public void emptyRun() {
67-
final Run r = new Run("1", "MyConnection", Arrays.asList());
68+
final Run r = new Run("1", "MyConnection", Collections.emptyList());
6869

6970
final String actual = r.toString();
7071

@@ -82,11 +83,11 @@ public void emptyRun() {
8283
sb.append(" \"executionTime\": null,\n");
8384
sb.append(" \"counter\": {\n");
8485
sb.append(" \"className\": \"Counter\",\n");
85-
sb.append(" \"disabled\": null,\n");
86-
sb.append(" \"success\": null,\n");
87-
sb.append(" \"failure\": null,\n");
88-
sb.append(" \"error\": null,\n");
89-
sb.append(" \"warning\": null\n");
86+
sb.append(" \"disabled\": 0,\n");
87+
sb.append(" \"success\": 0,\n");
88+
sb.append(" \"failure\": 0,\n");
89+
sb.append(" \"error\": 0,\n");
90+
sb.append(" \"warning\": 0\n");
9091
sb.append(" },\n");
9192
sb.append(" \"infoCount\": null,\n");
9293
sb.append(" \"errorStack\": null,\n");
@@ -95,15 +96,14 @@ public void emptyRun() {
9596
sb.append(" \"status\": null,\n");
9697
sb.append(" \"start\": null,\n");
9798
sb.append(" \"endTime\": null,\n");
98-
sb.append(" \"totalNumberOfCompletedTests\": -1\n");
99+
sb.append(" \"totalNumberOfCompletedTests\": 0\n");
99100
sb.append("}");
100-
Assert.assertEquals(sb.toString(), actual.toString());
101+
Assert.assertEquals(sb.toString(), actual);
101102
}
102103

103-
104104
@Test
105105
public void runWithTests() {
106-
final Run r = new Run("1", "MyConnection", Arrays.asList());
106+
final Run r = new Run("1", "MyConnection", Collections.emptyList());
107107
final org.utplsql.sqldev.model.runner.Test t1 = new org.utplsql.sqldev.model.runner.Test();
108108
t1.setId("1");
109109
t1.setName("Test One");
@@ -129,11 +129,11 @@ public void runWithTests() {
129129
sb.append(" \"executionTime\": null,\n");
130130
sb.append(" \"counter\": {\n");
131131
sb.append(" \"className\": \"Counter\",\n");
132-
sb.append(" \"disabled\": null,\n");
133-
sb.append(" \"success\": null,\n");
134-
sb.append(" \"failure\": null,\n");
135-
sb.append(" \"error\": null,\n");
136-
sb.append(" \"warning\": null\n");
132+
sb.append(" \"disabled\": 0,\n");
133+
sb.append(" \"success\": 0,\n");
134+
sb.append(" \"failure\": 0,\n");
135+
sb.append(" \"error\": 0,\n");
136+
sb.append(" \"warning\": 0\n");
137137
sb.append(" },\n");
138138
sb.append(" \"infoCount\": null,\n");
139139
sb.append(" \"errorStack\": null,\n");
@@ -145,7 +145,14 @@ public void runWithTests() {
145145
sb.append(" \"startTime\": null,\n");
146146
sb.append(" \"endTime\": null,\n");
147147
sb.append(" \"executionTime\": null,\n");
148-
sb.append(" \"counter\": null,\n");
148+
sb.append(" \"counter\": {\n");
149+
sb.append(" \"className\": \"Counter\",\n");
150+
sb.append(" \"disabled\": 0,\n");
151+
sb.append(" \"success\": 0,\n");
152+
sb.append(" \"failure\": 0,\n");
153+
sb.append(" \"error\": 0,\n");
154+
sb.append(" \"warning\": 0\n");
155+
sb.append(" },\n");
149156
sb.append(" \"errorStack\": null,\n");
150157
sb.append(" \"serverOutput\": null,\n");
151158
sb.append(" \"warnings\": null,\n");
@@ -168,7 +175,14 @@ public void runWithTests() {
168175
sb.append(" \"startTime\": null,\n");
169176
sb.append(" \"endTime\": null,\n");
170177
sb.append(" \"executionTime\": null,\n");
171-
sb.append(" \"counter\": null,\n");
178+
sb.append(" \"counter\": {\n");
179+
sb.append(" \"className\": \"Counter\",\n");
180+
sb.append(" \"disabled\": 0,\n");
181+
sb.append(" \"success\": 0,\n");
182+
sb.append(" \"failure\": 0,\n");
183+
sb.append(" \"error\": 0,\n");
184+
sb.append(" \"warning\": 0\n");
185+
sb.append(" },\n");
172186
sb.append(" \"errorStack\": null,\n");
173187
sb.append(" \"serverOutput\": null,\n");
174188
sb.append(" \"warnings\": null,\n");
@@ -189,8 +203,8 @@ public void runWithTests() {
189203
sb.append(" \"status\": null,\n");
190204
sb.append(" \"start\": null,\n");
191205
sb.append(" \"endTime\": null,\n");
192-
sb.append(" \"totalNumberOfCompletedTests\": -1\n");
206+
sb.append(" \"totalNumberOfCompletedTests\": 0\n");
193207
sb.append("}");
194-
Assert.assertEquals(sb.toString(), actual.toString());
208+
Assert.assertEquals(sb.toString(), actual);
195209
}
196210
}

0 commit comments

Comments
 (0)