do not restrict includables to the current user

PhilippSalvisberg · PhilippSalvisberg · commit e5b996aaeddf · 2018-10-21T11:37:26.000+02:00
use a hard-coded list of oracle_maintained_users based on 18.3
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/dal/UtplsqlDao.xtend b/sqldev/src/main/java/org/utplsql/sqldev/dal/UtplsqlDao.xtend
@@ -609,8 +609,17 @@ class UtplsqlDao {
 	 * gets dependencies of a given object. 
 	 * 
 	 * The result can be used as input for the includeObjectList in htmlCodeCoverage
-	 * The scope is reduced to the current schema.
-	 * This is useful when test packages are installed in the code schema.
+	 * The scope is reduced to non-oracle maintained schemas.
+	 * 
+	 * Oracle introduced the column ORACLE_MAINTAINED in 12.1.
+	 * To simplify the query and compatibility the result of the following 
+	 * query is included
+	 * 
+	 * SELECT '''' || listagg(username, ''', ''') || '''' AS oracle_maintained_users 
+     *  FROM dba_users 
+     * WHERE oracle_maintained = 'Y'
+     * ORDER BY username;
+	 * 
 	 * The result may include test packages
 	 * 
 	 * @param name test package name
@@ -622,7 +631,15 @@ class UtplsqlDao {
 			  from «IF dbaViewAccessible»dba«ELSE»all«ENDIF»_dependencies
 			  WHERE owner = user
 			    AND name = upper(?)
-			    AND referenced_owner = user
+			    AND referenced_owner NOT IN (
+			           'SYS', 'SYSTEM', 'XS$NULL', 'OJVMSYS', 'LBACSYS', 'OUTLN', 'SYS$UMF', 
+			           'DBSNMP', 'APPQOSSYS', 'DBSFWUSER', 'GGSYS', 'ANONYMOUS', 'CTXSYS', 
+			           'SI_INFORMTN_SCHEMA', 'DVF', 'DVSYS', 'GSMADMIN_INTERNAL', 'ORDPLUGINS', 
+			           'MDSYS', 'OLAPSYS', 'ORDDATA', 'XDB', 'WMSYS', 'ORDSYS', 'GSMCATUSER', 
+			           'MDDATA', 'REMOTE_SCHEDULER_AGENT', 'SYSBACKUP', 'GSMUSER', 'APEX_PUBLIC_USER', 
+			           'SYSRAC', 'AUDSYS', 'DIP', 'SYSKM', 'ORACLE_OCM', 'APEX_INSTANCE_ADMIN_USER', 
+			           'SYSDG', 'FLOWS_FILES', 'ORDS_METADATA', 'ORDS_PUBLIC_USER', 'APEX_180100'
+			        )
 			    AND referenced_type IN ('PACKAGE', 'TYPE', 'PROCEDURE', 'FUNCTION', 'TRIGGER')
 		'''
 		val jdbcTemplate = new JdbcTemplate(new SingleConnectionDataSource(conn, true))
diff --git a/sqldev/src/test/java/org/utplsql/sqldev/tests/DalTest.xtend b/sqldev/src/test/java/org/utplsql/sqldev/tests/DalTest.xtend
@@ -359,7 +359,7 @@ class DalTest extends AbstractJdbcTest {
 		val actualEmpty = dao.includes('TEST_F1')
 		Assert.assertEquals(#[], actualEmpty)
 		val actual = dao.includes('junit_utplsql_test_pkg')
-		Assert.assertEquals(#['JUNIT_UTPLSQL_TEST_PKG','JUNIT_F'], actual)
+		Assert.assertEquals(#['JUNIT_UTPLSQL_TEST_PKG','JUNIT_F','UT_EXPECTATION'], actual)
 	}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ class DalTest extends AbstractJdbcTest {`
`359`	`359`	`val actualEmpty = dao.includes('TEST_F1')`
`360`	`360`	`Assert.assertEquals(#[], actualEmpty)`
`361`	`361`	`val actual = dao.includes('junit_utplsql_test_pkg')`
`362`		`- Assert.assertEquals(#['JUNIT_UTPLSQL_TEST_PKG','JUNIT_F'], actual)`
	`362`	`+ Assert.assertEquals(#['JUNIT_UTPLSQL_TEST_PKG','JUNIT_F','UT_EXPECTATION'], actual)`
`363`	`363`	`}`
`364`	`364`
`365`	`365`	`}`