From 87eeda0da0330ee05d871be8cffded12b00064b8 Mon Sep 17 00:00:00 2001 From: Philipp Salvisberg Date: Sun, 28 Oct 2018 18:25:27 +0100 Subject: [PATCH 1/2] Fixes #47 - Close unshared connections --- .../main/java/org/utplsql/sqldev/UtplsqlWorksheet.xtend | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sqldev/src/main/java/org/utplsql/sqldev/UtplsqlWorksheet.xtend b/sqldev/src/main/java/org/utplsql/sqldev/UtplsqlWorksheet.xtend index ce788faf..1e80f4de 100644 --- a/sqldev/src/main/java/org/utplsql/sqldev/UtplsqlWorksheet.xtend +++ b/sqldev/src/main/java/org/utplsql/sqldev/UtplsqlWorksheet.xtend @@ -43,7 +43,14 @@ class UtplsqlWorksheet { private def setConnection(String connectionName) { if (connectionName !== null && preferences.unsharedWorksheet) { - this.connectionName = Connections.instance.createPrivateConnection(connectionName) + // fix for issue #47 - private connections are not closed in SQLDev >= 17.4.0 + try { + // temporary connection is closed when worksheet is closed, but requires SQLDev >= 17.4.0 + this.connectionName = Connections.instance.createTemporaryConnection(connectionName) + } catch (Throwable e) { + // private connection is closed when worksheet is closed in SQLDev < 17.4.0 + this.connectionName = Connections.instance.createPrivateConnection(connectionName) + } } else { this.connectionName = connectionName; } From fee82e50e6f79b15486981b1e992c70c1650d1ad Mon Sep 17 00:00:00 2001 From: Philipp Salvisberg Date: Sun, 28 Oct 2018 18:25:36 +0100 Subject: [PATCH 2/2] release v0.6.4 --- sqldev/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sqldev/pom.xml b/sqldev/pom.xml index 3880f964..411a813e 100644 --- a/sqldev/pom.xml +++ b/sqldev/pom.xml @@ -5,7 +5,7 @@ org.utplsql org.utplsql.sqldev - 0.6.3 + 0.6.4 bundle UTF-8