Skip to content

Coverage-Assets are not referenced correctly when writing to a sub-folder #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pesse opened this issue Jul 20, 2018 · 0 comments
Closed

Coverage-Assets are not referenced correctly when writing to a sub-folder #94

pesse opened this issue Jul 20, 2018 · 0 comments
Assignees
@pesse
Labels
bug
Milestone
3.1.1

Comments

@pesse
Copy link
Member

pesse commented Jul 20, 2018 •
edited
Loading

Finding by @tkleiber from #48

The new folder raises a problem in combination using directories in the -o switch eg.:
-o=results/ut_coverage_html_reporter.html

The resulting ut_coverage_html_reporter.html contains too the reference to this directory whis is wrong:
results/ut_coverage_html_reporter.html_assets/application.js

This should furthermore be:
ut_coverage_html_reporter.html_assets/application.js
as it must be relative to to html file location.

As workaround I change now into the directory before calling the cli and use -o without directories.
@pesse pesse added this to the 3.1.1 milestone Jul 20, 2018
@pesse pesse added the bug label Jul 20, 2018
@pesse pesse self-assigned this Jul 24, 2018
pesse added a commit that referenced this issue Jul 24, 2018
@pesse
CoverageHTML Reporter will now reference its assets correctly when ou…
7df3131 
…tput

is written to a subfolder.
Fixes #94
@pesse pesse mentioned this issue Jul 24, 2018
Merged
@pesse pesse closed this as completed in #95 Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pesse pesse

Labels
bug
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
1 participant
@pesse