Fix issues reported by sonarlint

viniciusam · viniciusam · commit 625a25fe349f · 2017-05-25T17:02:03.000-03:00
diff --git a/src/main/java/io/github/utplsql/api/DBHelper.java b/src/main/java/io/github/utplsql/api/DBHelper.java
@@ -12,6 +12,8 @@
  */
 public final class DBHelper {
 
+    private DBHelper() {}
+
     /**
      * Return a new sys_guid from database.
      * @param conn the connection
diff --git a/src/main/java/io/github/utplsql/api/OutputBuffer.java b/src/main/java/io/github/utplsql/api/OutputBuffer.java
@@ -66,7 +66,7 @@ public void fetchAvailable(Connection conn, Callback cb) throws SQLException {
         PreparedStatement preparedStatement = null;
         ResultSet resultSet = null;
         try {
-            preparedStatement = conn.prepareCall("SELECT * FROM table(ut_output_buffer.get_lines(?))");
+            preparedStatement = conn.prepareStatement("SELECT * FROM table(ut_output_buffer.get_lines(?))");
             preparedStatement.setString(1, getReporter().getReporterId());
             resultSet = preparedStatement.executeQuery();
 
diff --git a/src/main/java/io/github/utplsql/api/TestRunner.java b/src/main/java/io/github/utplsql/api/TestRunner.java
@@ -21,9 +21,6 @@ public class TestRunner {
     private List<String> includeObjects = new ArrayList<>();
     private List<String> excludeObjects = new ArrayList<>();
 
-    public TestRunner() {
-    }
-
     public TestRunner addPath(String path) {
         this.pathList.add(path);
         return this;
@@ -84,11 +81,11 @@ public void run(Connection conn) throws SQLException {
         OracleConnection oraConn = conn.unwrap(OracleConnection.class);
         Array pathArray = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.pathList.toArray());
         Array reporterArray = oraConn.createARRAY(CustomTypes.UT_REPORTERS, this.reporterList.toArray());
-        Array coverageSchemes = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.coverageSchemes.toArray());
-        Array sourceFiles = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.sourceFiles.toArray());
-        Array testFiles = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.testFiles.toArray());
-        Array includeObjects = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.includeObjects.toArray());
-        Array excludeObjects = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.excludeObjects.toArray());
+        Array coverageSchemesArray = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.coverageSchemes.toArray());
+        Array sourceFilesArray = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.sourceFiles.toArray());
+        Array testFilesArray = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.testFiles.toArray());
+        Array includeObjectsArray = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.includeObjects.toArray());
+        Array excludeObjectsArray = oraConn.createARRAY(CustomTypes.UT_VARCHAR2_LIST, this.excludeObjects.toArray());
 
         CallableStatement callableStatement = null;
         try {
@@ -101,11 +98,11 @@ public void run(Connection conn) throws SQLException {
                     "END;");
             callableStatement.setArray(1, pathArray);
             callableStatement.setArray(2, reporterArray);
-            callableStatement.setArray(3, coverageSchemes);
-            callableStatement.setArray(4, sourceFiles);
-            callableStatement.setArray(5, testFiles);
-            callableStatement.setArray(6, includeObjects);
-            callableStatement.setArray(7, excludeObjects);
+            callableStatement.setArray(3, coverageSchemesArray);
+            callableStatement.setArray(4, sourceFilesArray);
+            callableStatement.setArray(5, testFilesArray);
+            callableStatement.setArray(6, includeObjectsArray);
+            callableStatement.setArray(7, excludeObjectsArray);
             callableStatement.execute();
         } finally {
             if (callableStatement != null)
diff --git a/src/main/java/io/github/utplsql/api/reporter/ReporterFactory.java b/src/main/java/io/github/utplsql/api/reporter/ReporterFactory.java
@@ -15,8 +15,8 @@ public static Reporter createReporter(String reporterName) {
             case CustomTypes.UT_COVERALLS_REPORTER: return new CoverallsReporter();
             case CustomTypes.UT_COVERAGE_SONAR_REPORTER: return new CoverageSonarReporter();
             case CustomTypes.UT_SONAR_TEST_REPORTER: return new SonarTestReporter();
+            default: throw new RuntimeException("Reporter " + reporterName + " not implemented.");
         }
-        throw new RuntimeException("Reporter " + reporterName + " not implemented.");
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,8 @@ public static Reporter createReporter(String reporterName) {`
`15`	`15`	`case CustomTypes.UT_COVERALLS_REPORTER: return new CoverallsReporter();`
`16`	`16`	`case CustomTypes.UT_COVERAGE_SONAR_REPORTER: return new CoverageSonarReporter();`
`17`	`17`	`case CustomTypes.UT_SONAR_TEST_REPORTER: return new SonarTestReporter();`
	`18`	`+ default: throw new RuntimeException("Reporter " + reporterName + " not implemented.");`
`18`	`19`	`}`
`19`		`- throw new RuntimeException("Reporter " + reporterName + " not implemented.");`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`}`