Skip to content

Oracle depedency #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmuz opened this issue Apr 24, 2020 · 8 comments
Closed

Oracle depedency #56

dmuz opened this issue Apr 24, 2020 · 8 comments

Comments

@dmuz
Copy link

dmuz commented Apr 24, 2020

Hi,

Please change oracle depedencies to group
com.oracle.database.jdbc

Same version, published by Oracle, but PUBLIC - no login to Oracle required;)

@jgebal
Copy link
Member

jgebal commented Apr 24, 2020

@viniciusam @pesse
Is this dependency in maven plugin or in cli?
If it is easy to fix we could release next version with just that fix in it.

@viniciusam
Copy link
Member

My understanding is that the public group is "com.oracle.ojdbc" which is the one we're using on version 3.1.4, is this not the case?
https://medium.com/oracledevs/oracle-jdbc-drivers-on-maven-central-64fcf724d8b

@dmuz
Copy link
Author

dmuz commented Apr 26, 2020

Deps from com.oracle.ojdbc are public, but need license aproovment (oracle account / login)

Look at this:
https://mvnrepository.com/artifact/com.oracle.database.nls/orai18n
https://mvnrepository.com/artifact/com.oracle.database.jdbc/ojdbc8

@viniciusam
Copy link
Member

@jgebal if I make this change in the plugin it will probably work fine, but we should do it in the Java API too to avoid any compatibility issues:
https://github.com/utPLSQL/utPLSQL-java-api/blob/develop/build.gradle.kts#L42

@pesse
Copy link
Member

pesse commented Apr 29, 2020

You folks are right. I'll change dependency in java-api.
I checked and the only thing I did when the licensing changed was to ship the JARs together with CLI, but didn't change the dependencies.
Will try to do that change and create a new java-api version quickly

@pesse
Copy link
Member

pesse commented Apr 29, 2020

The link vinicius provided announces both the group-id change and the availability on maven central.
Completely missed that - it was unfortunately not the case back when I did the cli shipping change in October.

@pesse
Copy link
Member

pesse commented Apr 29, 2020

I need to correct myself (too tired or diverted right now) once more.
This is the latest announcement of Kuassi Mensah about the change of group-ids from Feb 2020: https://medium.com/oracledevs/all-in-and-new-groupids-oracle-jdbc-drivers-on-maven-central-a76d545954c6
@viniciusam linked an earlier announcement of September 2019 where the group-id change was not announced.

@simasch
Copy link
Member

simasch commented Nov 19, 2021

Obsolete

@simasch simasch closed this as completed Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants