Skip to content

DEBUG: workarea for inspecting the errors aabout lsns/filter test case #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

DEBUG: workarea for inspecting the errors aabout lsns/filter test case #3205

wants to merge 5 commits into from

Conversation

masatake
Copy link
Member

No description provided.

@masatake masatake force-pushed the lsns--filter-debug branch 4 times, most recently from 7a0f545 to 2de2143 Compare September 19, 2024 21:24
@masatake
Copy link
Member Author

The issue can be constantly reproducible with fewer computing resources.

         lsns: -Q, --filter option                           ... OK
         lsns: -Q, --filter option                           ... OK
         lsns: -Q, --filter option                           ... OK
         lsns: -Q, --filter option                           ... OK

diff-{{{
--- /builddir/build/BUILD/util-linux-2.41.devel-build/util-linux-2.41.devel/tests/expected/lsns/filter14	2024-09-19 21:24:05.000000000 +0000
+++ /builddir/build/BUILD/util-linux-2.41.devel-build/util-linux-2.41.devel/tests/output/lsns/filter14	2024-09-19 21:33:47.103436699 +0000
@@ -1,2 +1,3 @@
 -Q: pid == PID
+lsns: Unsupported ioctl NS_GET_NSTYPE
 --filter: pid == PID
}}}-diff

         lsns: -Q, --filter option                           ... OK

I run lsns/filter test repeatedly. The original issue is that lsns cannot find a namespace or cannot report the pid in a namespace that lsfs finds.

However, "Unsupported ioctl NS_GET_NSTYPE" was reported once. Looks like a very different bug.

@masatake masatake mentioned this pull request Sep 23, 2024
Merged
@masatake masatake mentioned this pull request Oct 1, 2024
Open
@karelzak
Copy link
Collaborator

What about changing the test to TS_KNOWN_FAIL="yes"? :-)

@masatake
Copy link
Member Author

What about changing the test to TS_KNOWN_FAIL="yes"? :-)

I will make a pull request.

@masatake masatake force-pushed the lsns--filter-debug branch from d155c45 to 1a6ebbf Compare January 8, 2025 21:16
@masatake masatake force-pushed the lsns--filter-debug branch from 1a6ebbf to 61a4496 Compare January 8, 2025 21:34
@masatake
Copy link
Member Author

masatake commented Jan 8, 2025 

         lsns: -Q, --filter option                           ... FAILED (lsns/filter11)
         lsns: -Q, --filter option                           ... OK
        ...
         lsns: -Q, --filter option                           ... OK
         lsns: -Q, --filter option                           ... OK
         lsns: -Q, --filter option                           ... OK

---------------------------------------------------------------------
  1 tests of 32 FAILED

      lsns/filter11
---------------------------------------------------------------------

After rebasing on the latest master branch, the issue reproduced but it is rare case.

On ppc64le "+lsns: Unsupported ioctl NS_GET_NSTYPE" was reported.
On s390x, x86_64, and aarch64 the error was not reported.

I will inspect this NS_GET_NSTYPE before marking TS_KNOWN_FAIL="yes" on the test case.

@masatake
DEBUG: retry NS_GET_NSTYPE if it fails
a0c428c 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
karelzak added a commit that referenced this pull request Feb 18, 2025
@karelzak
tests: mark lsns/filer as TS_KNOWN_FAIL
f589580 
Let's make the test more robust for stable/ branch.

Addresses: #3205
Signed-off-by: Karel Zak <kzak@redhat.com>
karelzak added a commit to karelzak/util-linux-work that referenced this pull request Apr 1, 2025
@karelzak
tests: mark lsns/filer as TS_KNOWN_FAIL
d2dadb7 
Let's make the test more robust for stable/ branch.

Addresses: util-linux#3205
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit f589580)
@masatake masatake mentioned this pull request May 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masatake @karelzak