fix possible cross-platform issue that code failing to pass on some tests

Kev1n8 · Kev1n8 · commit 98d26f20e9b9 · 2024-07-01T00:55:41.000+08:00
diff --git a/src/uucore/src/lib/features/format/spec.rs b/src/uucore/src/lib/features/format/spec.rs
@@ -374,7 +374,7 @@ impl Spec {
                 let precision = resolve_asterisk(*precision, &mut args)?.unwrap_or(0);
                 let i = args.get_i64();
 
-                if precision > i32::MAX as usize {
+                if precision as u64 > i32::MAX as u64 {
                     return Err(FormatError::InvalidPrecision(precision.to_string()));
                 }
 
@@ -397,7 +397,7 @@ impl Spec {
                 let precision = resolve_asterisk(*precision, &mut args)?.unwrap_or(0);
                 let i = args.get_u64();
 
-                if precision > i32::MAX as usize {
+                if precision as u64 > i32::MAX as u64 {
                     return Err(FormatError::InvalidPrecision(precision.to_string()));
                 }
 
@@ -423,7 +423,7 @@ impl Spec {
                 let precision = resolve_asterisk(*precision, &mut args)?.unwrap_or(6);
                 let f = args.get_f64();
 
-                if precision > i32::MAX as usize {
+                if precision as u64 > i32::MAX as u64 {
                     return Err(FormatError::InvalidPrecision(precision.to_string()));
                 }
 
diff --git a/tests/by-util/test_printf.rs b/tests/by-util/test_printf.rs
@@ -788,7 +788,7 @@ fn invalid_precision_fails() {
 fn float_invalid_precision_fails() {
     // It is invalid to have length of output string greater than i32::MAX
     new_ucmd!()
-        .args(&["%.*f", "9999999999", "0"])
+        .args(&["%.*f", "2147483648", "0"])
         .fails()
-        .stderr_is("printf: invalid precision: '9999999999'\n");
+        .stderr_is("printf: invalid precision: '2147483648'\n");
 }

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,7 @@ impl Spec {`
`374`	`374`	`let precision = resolve_asterisk(*precision, &mut args)?.unwrap_or(0);`
`375`	`375`	`let i = args.get_i64();`
`376`	`376`
`377`		`- if precision > i32::MAX as usize {`
	`377`	`+ if precision as u64 > i32::MAX as u64 {`
`378`	`378`	`return Err(FormatError::InvalidPrecision(precision.to_string()));`
`379`	`379`	`}`
`380`	`380`
`@@ -397,7 +397,7 @@ impl Spec {`
`397`	`397`	`let precision = resolve_asterisk(*precision, &mut args)?.unwrap_or(0);`
`398`	`398`	`let i = args.get_u64();`
`399`	`399`
`400`		`- if precision > i32::MAX as usize {`
	`400`	`+ if precision as u64 > i32::MAX as u64 {`
`401`	`401`	`return Err(FormatError::InvalidPrecision(precision.to_string()));`
`402`	`402`	`}`
`403`	`403`
`@@ -423,7 +423,7 @@ impl Spec {`
`423`	`423`	`let precision = resolve_asterisk(*precision, &mut args)?.unwrap_or(6);`
`424`	`424`	`let f = args.get_f64();`
`425`	`425`
`426`		`- if precision > i32::MAX as usize {`
	`426`	`+ if precision as u64 > i32::MAX as u64 {`
`427`	`427`	`return Err(FormatError::InvalidPrecision(precision.to_string()));`
`428`	`428`	`}`
`429`	`429`