tail: Fix printed header for stdin should be the same on all platforms

Joining7943 · Joining7943 · commit ae60045f3f0c · 2023-04-21T21:55:28.000+02:00
diff --git a/src/uu/tail/src/paths.rs b/src/uu/tail/src/paths.rs
@@ -10,7 +10,10 @@ use std::ffi::OsStr;
 use std::fs::{File, Metadata};
 use std::io::{Seek, SeekFrom};
 #[cfg(unix)]
-use std::os::unix::fs::{FileTypeExt, MetadataExt};
+use std::os::unix::{
+    fs::{FileTypeExt, MetadataExt},
+    prelude::OsStrExt,
+};
 use std::path::{Path, PathBuf};
 use uucore::error::UResult;
 
@@ -20,6 +23,30 @@ pub enum InputKind {
     Stdin,
 }
 
+#[cfg(unix)]
+impl From<&OsStr> for InputKind {
+    fn from(value: &OsStr) -> Self {
+        const DASH: [u8; 1] = [b'-'];
+
+        if value.as_bytes() == DASH {
+            Self::Stdin
+        } else {
+            Self::File(PathBuf::from(value))
+        }
+    }
+}
+
+#[cfg(not(unix))]
+impl From<&OsStr> for InputKind {
+    fn from(value: &OsStr) -> Self {
+        if value == OsStr::new(text::DASH) {
+            Self::Stdin
+        } else {
+            Self::File(PathBuf::from(value))
+        }
+    }
+}
+
 #[derive(Debug, Clone)]
 pub struct Input {
     kind: InputKind,
@@ -29,21 +56,11 @@ pub struct Input {
 impl Input {
     pub fn from<T: AsRef<OsStr>>(string: T) -> Self {
         let string = string.as_ref();
-        let kind = if string == OsStr::new(text::DASH) {
-            InputKind::Stdin
-        } else {
-            InputKind::File(PathBuf::from(string))
-        };
 
+        let kind = string.into();
         let display_name = match kind {
             InputKind::File(_) => string.to_string_lossy().to_string(),
-            InputKind::Stdin => {
-                if cfg!(unix) {
-                    text::STDIN_HEADER.to_string()
-                } else {
-                    string.to_string_lossy().to_string()
-                }
-            }
+            InputKind::Stdin => text::STDIN_HEADER.to_string(),
         };
 
         Self { kind, display_name }
diff --git a/tests/by-util/test_tail.rs b/tests/by-util/test_tail.rs
@@ -145,12 +145,8 @@ fn test_stdin_redirect_offset() {
 }
 
 #[test]
-#[cfg(all(not(target_vendor = "apple"), not(target_os = "windows")))] // FIXME: for currently not working platforms
+#[cfg(all(not(target_vendor = "apple")))] // FIXME: for currently not working platforms
 fn test_stdin_redirect_offset2() {
-    // FIXME: windows: Failed because of difference in printed header. See below.
-    // actual  : ==> - <==
-    // expected: ==> standard input <==
-
     // like test_stdin_redirect_offset but with multiple files
 
     let ts = TestScenario::new(util_name!());
