apply simple clippy nightly suggestions

BenWiederhake · BenWiederhake · commit e4acb7c583cd · 2025-04-13T04:19:21.000+02:00
See also: https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_some https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
diff --git a/src/uu/cp/src/copydir.rs b/src/uu/cp/src/copydir.rs
@@ -82,7 +82,7 @@ fn get_local_to_root_parent(
 /// Given an iterator, return all its items except the last.
 fn skip_last<T>(mut iter: impl Iterator<Item = T>) -> impl Iterator<Item = T> {
     let last = iter.next();
-    iter.scan(last, |state, item| std::mem::replace(state, Some(item)))
+    iter.scan(last, |state, item| state.replace(item))
 }
 
 /// Paths that are invariant throughout the traversal when copying a directory.
diff --git a/src/uu/fmt/src/linebreak.rs b/src/uu/fmt/src/linebreak.rs
@@ -164,9 +164,7 @@ fn break_knuth_plass<'a, T: Clone + Iterator<Item = &'a WordInfo<'a>>>(
 
                 // We find identical breakpoints here by comparing addresses of the references.
                 // This is OK because the backing vector is not mutating once we are linebreaking.
-                let winfo_ptr = winfo as *const _;
-                let next_break_ptr = next_break as *const _;
-                if winfo_ptr == next_break_ptr {
+                if std::ptr::eq(winfo, next_break) {
                     // OK, we found the matching word
                     if break_before {
                         write_newline(args.indent_str, args.ostream)?;
diff --git a/src/uu/unexpand/src/unexpand.rs b/src/uu/unexpand/src/unexpand.rs
@@ -55,7 +55,7 @@ fn tabstops_parse(s: &str) -> Result<Vec<usize>, ParseError> {
         }
     }
 
-    if nums.iter().any(|&n| n == 0) {
+    if nums.contains(&0) {
         return Err(ParseError::TabSizeCannotBeZero);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ fn get_local_to_root_parent(`
`82`	`82`	`/// Given an iterator, return all its items except the last.`
`83`	`83`	`fn skip_last<T>(mut iter: impl Iterator<Item = T>) -> impl Iterator<Item = T> {`
`84`	`84`	`let last = iter.next();`
`85`		`- iter.scan(last, \|state, item\| std::mem::replace(state, Some(item)))`
	`85`	`+ iter.scan(last, \|state, item\| state.replace(item))`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`/// Paths that are invariant throughout the traversal when copying a directory.`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ fn tabstops_parse(s: &str) -> Result<Vec<usize>, ParseError> {`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`
`58`		`- if nums.iter().any(\|&n\| n == 0) {`
	`58`	`+ if nums.contains(&0) {`
`59`	`59`	`return Err(ParseError::TabSizeCannotBeZero);`
`60`	`60`	`}`
`61`	`61`