Skip to content

the mv command takes a long time even if the src and dest on same device. #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hamflx opened this issue Feb 29, 2024 · 3 comments · Fixed by #6040
Closed

the mv command takes a long time even if the src and dest on same device. #6029

hamflx opened this issue Feb 29, 2024 · 3 comments · Fixed by #6040
Labels
U - mv

Comments

@hamflx
Copy link
Contributor

hamflx commented Feb 29, 2024 •
edited
Loading

see

reproduce:

  • clone a large front-end project, on Windows
  • npm install
  • cd node_modules to simulate a file being locked by a process
  • Open a new shell.
  • Run mv node_modules \.nd This command will take a long time and then fail.

is possible to change the fallback to copy only when the std::fs::rename report an ERROR_NOT_SAME_DEVICE/EXDEV error? this will failed immediately rather than takes a long time and then failed.

now it always trying to copy, even if it just an permission error, this takes a long time, and then failed again.
@hamflx
Copy link
Contributor Author

hamflx commented Mar 1, 2024

like this: main...hamflx:coreutils:main#diff-fc9209d88cfefac46cf90a30d3d80113d5afb85df15f646aae70d8c51d76b7c9R594

@tertsdiepraam
Copy link
Member

Sounds interesting to explore at least. Could you open a PR with that diff?

@hamflx hamflx mentioned this issue Mar 2, 2024
Merged
@hamflx
Copy link
Contributor Author

hamflx commented Mar 2, 2024

@tertsdiepraam I have created a pr. but i'm not sure if my changes have side effects.

@jfinkels jfinkels mentioned this issue Jan 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
U - mv
Projects
None yet
Milestone
No milestone
3 participants
@cakebaker @tertsdiepraam @hamflx