-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Run all workspace tests in CI (Windows) #7397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looked a bit into this, the main problem is that It's possible to add
Maybe best for somebody with an actual Windows machine to try to fix this. Or maybe we could find a way to be more selective about which packages we actually run tests on. |
I have an actual Windows machine an would like to do something. |
I made some attempt in #7591, not sure if this is the right approach, would be awesome if you can give this a try! |
some tests rely on the seq command to produce test data,which is not available on windows。Maybe we need to use powershell instead on windows. |
Which tests? I wonder if we can get rid of that dependency and just generate the test data in Rust directly. |
One of them is test_all_but_last_bytes_large_file_piped, in file |
I'm a bit confused, Or maybe you are trying to get more tests to pass without all the harness that CI normally sets up? That might not be a bad idea, but it's a bit orthogonal to what I was thinking about here (pass |
I'm not familiar with the CI of github, just found something about msys64 in the CICD.yml file. So should i run |
Similar to #7392, it would be nice to run all tests in CI, on MacOS (basically adding workspace-tests: true to some windows jobs in the matrix).
When I tried in #7386, I hit this issue:
I think
libstdbuf.rs
should simply not be built on Windows platform -- AFAICT nothing that is supported on Windows uses it.Of course, there might be some more issues after this.
The text was updated successfully, but these errors were encountered: