ls: Improve the access to metadata of the files #5660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge. I need to simplify the color_name function |
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 18, 2023
cakebaker
reviewed
Dec 18, 2023
src/uu/ls/src/ls.rs
Outdated
| ls_colors: &LsColors, | ||
| style_manager: &mut StyleManager, | ||
| out: &mut BufWriter<Stdout>, | ||
| check_for_deref: bool, |
There was a problem hiding this comment.
check_for_deref seems unnecessary to me because its value is linked to target_symlink: it's true if target_symlink is Some(..), and false, if target_symlink is None. And as color_name is only called twice, it might make sense to split the function into two functions.
There was a problem hiding this comment.
wahou, well spotted, bravo :)
cakebaker
reviewed
Dec 18, 2023
…tat-free-color.sh
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix tests/ls/stat-free-color.sh