ls: fixed incorrect alignment when using --classify option #7593
+3
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
Yeah, but this breaks #5396 , which required this change to be introduced |
|
is it still relevant ? thanks |
|
It's outdated due to #7616. Thanks for the contribution though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the insertion of tabs instead of spaces when using the
--classifyor-Foption seems to fix the mentioned issue. All of the tests pass, except for one, which obviously checks for tabs, which my fix changed.It seems to me that the
uutils_term_gridcrate cannot properly align columns when using tabs as text.With the fix, sometimes the alignment differs from the GNU implementation of ls, but I don't know how much of an issue that is.
fixes #7526