implement locate and updatedb #536
Open
+1,436
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Apr 14, 2025
sylvestre
reviewed
Apr 14, 2025
|
cool, thanks :) |
|
add please add tests :) |
afeae83 to
eeb7ab5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
==========================================
+ Coverage 87.69% 87.80% +0.10%
==========================================
Files 31 35 +4
Lines 6893 6937 +44
Branches 324 355 +31
==========================================
+ Hits 6045 6091 +46
+ Misses 617 597 -20
- Partials 231 249 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eeb7ab5 to
ae7b831
Compare
|
A couple notes:
|
sylvestre
reviewed
Apr 16, 2025
src/db_tests.rs
Outdated
| @@ -0,0 +1,79 @@ | |||
| // Copyright 2017 Google Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2017 Google Inc. |
sylvestre
reviewed
Apr 16, 2025
be54aac to
26982d5
Compare
sylvestre
reviewed
May 11, 2025
sylvestre
reviewed
May 11, 2025
sylvestre
reviewed
May 11, 2025
sylvestre
reviewed
May 11, 2025
sylvestre
reviewed
May 11, 2025
sylvestre
reviewed
May 12, 2025
| @@ -0,0 +1,335 @@ | |||
| // Copyright 2017 Google Inc. | |||
There was a problem hiding this comment.
Same, please remove that line and the others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #60
Given that locate has largely been replaced by (m|p)locate, I was unable to find a version of locate packaged for my system (latest Arch Linux), and the packaged version of updatedb does not use the LOCATE02 db format. When running updatedb from source, I encountered errors that were not immediately fixable. As such, this implementation is largely untested, but it's better to have something here to be improved upon.