Skip to content

Replace the regex parser with winnow-based parse #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2025
Merged

Replace the regex parser with winnow-based parse #137

merged 4 commits into from
May 9, 2025

Conversation

yuankunzhang
Copy link
Contributor

Revamp of #86.

@yuankunzhang yuankunzhang marked this pull request as draft May 1, 2025 13:06
@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch 3 times, most recently from 1fbb6ec to befe2ec Compare May 1, 2025 13:19
@yuankunzhang yuankunzhang marked this pull request as ready for review May 1, 2025 13:20
@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch from befe2ec to bd8b226 Compare May 1, 2025 14:40
tertsdiepraam
tertsdiepraam reviewed May 1, 2025
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot! I've just reviewed your changes for now and I'll try to get a full review done soon. We could also just merge this and fix issues later as I think at least the structure is good.

@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch from bd8b226 to 398ed93 Compare May 2, 2025 12:42
@yuankunzhang yuankunzhang mentioned this pull request May 2, 2025
Merged
@yuankunzhang
Copy link
Contributor Author

@tertsdiepraam Could I get some attention on this PR please?

@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch from 398ed93 to 333efc7 Compare May 6, 2025 13:55
@tertsdiepraam
Copy link
Member

Thanks for reminding me! I'll put it on my todo list for tomorrow

tertsdiepraam
tertsdiepraam reviewed May 7, 2025
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny comments, but I think this should be merged soon! Well done!

@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch from 333efc7 to be56773 Compare May 7, 2025 13:33
@yuankunzhang
Copy link
Contributor Author

@tertsdiepraam Thanks for the review! All comments are addressed.

@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch from be56773 to bc6b70b Compare May 7, 2025 13:54
@tertsdiepraam tertsdiepraam merged commit 77156f4 into uutils:main May 9, 2025
14 checks passed
@codecov Codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (b481a2b) to head (bc6b70b).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff     @@
##   main   #137   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tertsdiepraam
Copy link
Member

Thank you! I'm so glad we finally got this to a mergeable state!

@tertsdiepraam tertsdiepraam mentioned this pull request May 9, 2025
Closed
@yuankunzhang yuankunzhang mentioned this pull request May 11, 2025
Closed
@drinkcat drinkcat mentioned this pull request May 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuankunzhang @tertsdiepraam @sylvestre @dhilst