fix nightly clippy warnings

BenWiederhake · BenWiederhake · commit df7bc4e2d9a8 · 2024-05-09T21:15:00.000+02:00
Note that this still compiles warning-free with rustc 1.70.
diff --git a/derive/Cargo.toml b/derive/Cargo.toml
@@ -6,7 +6,7 @@ edition = "2021"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [lib]
-proc_macro = true
+proc-macro = true
 
 [dependencies]
 proc-macro2 = "1.0.81"
diff --git a/derive/src/argument.rs b/derive/src/argument.rs
@@ -13,7 +13,6 @@ use crate::{
 pub struct Argument {
     pub ident: Ident,
     pub field: Option<syn::Type>,
-    pub name: String,
     pub arg_type: ArgType,
     pub help: String,
 }
@@ -41,7 +40,6 @@ pub fn parse_arguments_attr(attrs: &[Attribute]) -> ArgumentsAttr {
 
 pub fn parse_argument(v: Variant) -> Vec<Argument> {
     let ident = v.ident;
-    let name = ident.to_string();
     let attributes = get_arg_attributes(&v.attrs).unwrap();
 
     // Return early because we don't need to check the fields if it's not used.
@@ -94,7 +92,6 @@ pub fn parse_argument(v: Variant) -> Vec<Argument> {
             Argument {
                 ident: ident.clone(),
                 field: field.clone(),
-                name: name.clone(),
                 arg_type,
                 help: arg_help,
             }
diff --git a/tests/options.rs b/tests/options.rs
@@ -286,7 +286,7 @@ fn actions() {
         fn apply(&mut self, arg: Arg) {
             match arg {
                 Arg::Message(m) => {
-                    self.last_message = m.clone();
+                    self.last_message.clone_from(&m);
                     self.messages.push(m);
                 }
                 Arg::Send => self.send = true,
@@ -617,6 +617,7 @@ fn empty_value() {
         Val(V),
     }
 
+    #[allow(dead_code)]
     struct Settings {}
 
     impl Options<Arg> for Settings {

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ fn actions() {`
`286`	`286`	`fn apply(&mut self, arg: Arg) {`
`287`	`287`	`match arg {`
`288`	`288`	`Arg::Message(m) => {`
`289`		`- self.last_message = m.clone();`
	`289`	`+ self.last_message.clone_from(&m);`
`290`	`290`	`self.messages.push(m);`
`291`	`291`	`}`
`292`	`292`	`Arg::Send => self.send = true,`
`@@ -617,6 +617,7 @@ fn empty_value() {`
`617`	`617`	`Val(V),`
`618`	`618`	`}`
`619`	`619`
	`620`	`+ #[allow(dead_code)]`
`620`	`621`	`struct Settings {}`
`621`	`622`
`622`	`623`	`impl Options<Arg> for Settings {`