Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tlconnor/activerecord-postgres-array
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: vacationlabs/activerecord-postgres-array
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 8 files changed
  • 2 contributors

Commits on Aug 11, 2013

  1. Added support for parsing multi-dimensional array string

    * Used the Sequel::Postgres::PGArray::Parser class from
      https://github.com/jeremyevans/sequel/blob/master/lib/sequel/extensions/pg_array.rb
    * The saner method to parse multi-dimensional array-strings
      is to NOT use regexps and use some sort of parser instead
    * Changed String.valid_postgres_array? to use constants instead
      of variables to defined the regexps
    * Converting timestamps to current Rails timezone using `in_time_zone`
    saurabhnanda committed Aug 11, 2013
    Configuration menu
    Copy the full SHA
    a3da0f9 View commit details
    Browse the repository at this point in the history
  2. Removed String.valid_postgres_array?

    Removed String.valid_postgres_array? because there is no easy way to
    validate array-string using Regexps alone. One will have to parse the
    string into an array to check if it's valid -- a task that the PG database
    would anyways do.
    
    Removed check in `quote_with_array`
    saurabhnanda committed Aug 11, 2013
    Configuration menu
    Copy the full SHA
    d46eb02 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a007a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5630623 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2013

  1. fixed a typo

    saurabhnanda committed Aug 24, 2013
    Configuration menu
    Copy the full SHA
    9deaf08 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2014

  1. Configuration menu
    Copy the full SHA
    2ef39d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2014

  1. * Removed the monkeypatch for ActiveRecord::Base#arel_attributes_valu…

    …es because the actual function in Rails 3.2.x has changed. The monkeypatched version was unable to handle serialized attributes and was causing all serializations to barf.
    
    * Removed the method_chaing for quote_without_array, because it's not required in the new approach.
    * Added ActiveRecord::Coders::PgArray to act as a serializer/de-serializer for all array columns. One has to expilicity define how to serialize a column, like:
        `serialize :tags, ActiveRecord::Coders::PgArray(:string)`
    saurabhnanda committed Dec 11, 2014
    Configuration menu
    Copy the full SHA
    061d430 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2014

  1. Configuration menu
    Copy the full SHA
    6b7ff20 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2014

  1. fixes to make sure read_attribute works for postrgres arrays, even if…

    … we override the reader method
    saurabhnanda committed Dec 26, 2014
    Configuration menu
    Copy the full SHA
    a006ed6 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2015

  1. Configuration menu
    Copy the full SHA
    a16136b View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2015

  1. Configuration menu
    Copy the full SHA
    e5eaef7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'rails-3.2'

    ashwinsaval committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    0b664c5 View commit details
    Browse the repository at this point in the history
Loading