Skip to content

vcs-registry: All vcspull compatible URLs must have URLs detected #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 25, 2022
Merged

vcs-registry: All vcspull compatible URLs must have URLs detected #420

merged 7 commits into from
Sep 25, 2022

Conversation

tony
Copy link
Member

@tony tony commented Sep 23, 2022 •
edited
Loading

Required by vcs-python/vcspull#373

and i dont have time to do this until the weekend

Todo:

  • copy over all possible URL combinations that can happen in .vcspull.yaml configurations
    • add them to a massive pytest.parametrize test grid
    • all of them must ✅ pass
    • To be very generous, even try to allow git+ssh://git@github.com:tony/pytest.git (mix of copying from github + a pip url)
  • see how / if remotes should be resolved on libvcs (and if so, which module) or in vcspull

@tony tony mentioned this pull request Sep 23, 2022
Merged
@tony tony force-pushed the vcs-registry branch 2 times, most recently from 1754c10 to 3753707 Compare September 24, 2022 16:31
@codecov
Copy link

codecov bot commented Sep 24, 2022 •
edited
Loading

Codecov Report

Merging #420 (79d9b01) into master (1a14726) will increase coverage by 0.17%.
The diff coverage is 67.32%.

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   62.00%   62.17%   +0.17%     
==========================================
  Files          36       39       +3     
  Lines        2811     2911     +100     
  Branches      675      695      +20     
==========================================
+ Hits         1743     1810      +67     
- Misses        640      667      +27     
- Partials      428      434       +6
Impacted Files Coverage Δ
src/libvcs/_internal/module_loading.py 39.02% <39.02%> (ø)
src/libvcs/_internal/shortcuts.py 75.00% <57.14%> (-11.96%) ⬇️
tests/url/test_registry.py 95.45% <95.45%> (ø)
src/libvcs/url/registry.py 95.83% <95.83%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the vcs-registry branch 5 times, most recently from ad87abd to 158c53f Compare September 24, 2022 21:43
@tony tony changed the title Note to self, vcs-registry: All vcspull compatible URLs must have URLs detected vcs-registry: All vcspull compatible URLs must have URLs detected Sep 24, 2022
@tony tony force-pushed the vcs-registry branch 3 times, most recently from 6c5cda0 to 7e236f8 Compare September 25, 2022 00:37
@tony tony mentioned this pull request Sep 25, 2022
Merged
@tony tony force-pushed the vcs-registry branch 5 times, most recently from 884dc27 to efc7bc6 Compare September 25, 2022 11:11
@tony tony merged commit b0ac185 into master Sep 25, 2022
@tony tony deleted the vcs-registry branch September 25, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tony