Fix sockjs#91 - in some rare corner cases, for *-streaming closing might have triggered null exception

majek · majek · commit 81ce634d0bd4 · 2012-10-08T14:29:18.000+01:00
Basically, when the close frame went above the data-per-straming connection limit.
diff --git a/src/transport.coffee b/src/transport.coffee
@@ -331,9 +331,11 @@ class Session
         @readyState = Transport.CLOSING
         @close_frame = closeFrame(status, reason)
         if @recv
-            # Go away.
+            # Go away. doSendFrame can trigger didClose which can
+            # trigger unregister. Make sure the @recv is not null.
             @recv.doSendFrame(@close_frame)
-            @recv.didClose()
+            if @recv
+                @recv.didClose()
             if @recv
                 @unregister()
         return true
