-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbled characters appear in the Chinese directory(windows-terminal) #1034
Comments
CJK on Windows is problematic (at least when using PDCurses, as Vifm does). There were previous reports related to Windows Terminal which were "resolved" by:
I still don't know why it happens and whether there is an actual issue on Vifm side (PDCurses, really, but I patch it to make CJK work on Windows at all) given that the outcome depends on the version of WT. Will need to give it a try again, maybe will be more lucky. Please post problematic Chinese file names as text here so I can use them for a test in case the behaviour depends on some specific text. |
Thanks, and i will help you to solve this problem(it bothered me for a long time). File names工程伦理.md |
Thanks, judging by the dates:
So far it looks like a problem with WT. Might be able to bisect it a bit to possibly extract some information. |
As reference, Far Manager also has same problem with default setting. But, if check "Fullwidth-aware rendering" option in "Interface Settings", the problem will be fixed. And this wt Issule os: win11 |
Thanks, @vodbyte. I'm yet to test it, but I likely understand what's going on: WT changed how it treats wide characters multiple times. The patch which I apply to pdcurses pads characters that are wider than a single cell (so a Chinese character is printed as 2 characters to tell the terminal that 2 cells are used), because that makes it work with |
Not adding an option, because it doesn't seem to be helpful. After dropping the padding from the output and switching to PDCurses v3.9, both new and old WT seem to display things well: Testing it in cmder, pure ConEmu, cmd.exe didn't reveal any regressions. Quite the opposite, ConEmu now displays CJK well unless you use colors >= 16 while previously the output didn't look good regardless of the colors. You can grab latest Windows builds from https://builds.vifm.info/ to test. |
In windows-termianl 1.21, vifm can not work when director's name or file's name is Chinese.

The text was updated successfully, but these errors were encountered: