Fix FactorAnalysis not to install its package by default

minjk-bl · minjk-bl · commit 0c87e7186f67 · 2023-08-22T18:29:03.000+09:00
diff --git a/visualpython/js/m_stats/FactorAnalysis.js b/visualpython/js/m_stats/FactorAnalysis.js
@@ -160,21 +160,19 @@ define([
         }
 
         generateInstallCode() {
-            return [ '!pip install factor-analyzer'];
+            let installCode = '!pip install factor-analyzer';
+            // Add installation code
+            if (vpConfig.extensionType === 'lite') {
+                installCode = '%pip install factor-analyzer';
+            }
+            return [ installCode ];
         }
 
         generateCode() {
             let { data, variable, rotation, method, impute, extract, eigenvalue, factor, corrMatrix, screePlot } = this.state;
             let codeList = [];
             let code = new com_String();
 
-            // Add installation code FIXME:
-            if (vpConfig.extensionType === 'lite') {
-                codeList.push('%pip install factor-analyzer');
-            } else {
-                codeList.push('!pip install factor-analyzer');
-            }
-
             // data declaration
             code.appendFormat("vp_df = {0}", data);
             if (this.columnSelector) {
