Skip to content

Commit 25e48c8

Browse files
author
minjk-bl
committed
Fix bindColumnSource bug - 0 binds with default value
1 parent 369444d commit 25e48c8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

js/com/com_generatorV2.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ define([
683683
// reset with no source
684684
columnInputIdList && columnInputIdList.forEach(columnInputId => {
685685
let defaultValue = pageThis.state[columnInputId];
686-
if (defaultValue == null || defaultValue == undefined) {
686+
if (defaultValue === null || defaultValue === undefined) {
687687
defaultValue = '';
688688
}
689689
if (tagType == 'input') {
@@ -745,7 +745,7 @@ define([
745745
// columns using suggestInput
746746
columnInputIdList && columnInputIdList.forEach((columnInputId, idx) => {
747747
let defaultValue = pageThis.state[columnInputId];
748-
if (defaultValue == null || defaultValue == undefined) {
748+
if (defaultValue === null || defaultValue === undefined) {
749749
defaultValue = '';
750750
}
751751
// create tag
@@ -774,7 +774,7 @@ define([
774774
'data-type':listVar.dtype
775775
});
776776
// cell metadata test : defaultValue as selected
777-
if (listVar.value == defaultValue) {
777+
if (listVar.value === defaultValue) {
778778
$(option).prop('selected', true);
779779
}
780780
option.append(document.createTextNode(listVar.label));

0 commit comments

Comments
 (0)