Skip to content

Commit 87f2c66

Browse files
author
minjk-bl
committed
Fix File > json options
1 parent d4a1346 commit 87f2c66

File tree

2 files changed

+29
-3
lines changed

2 files changed

+29
-3
lines changed

data/m_library/pandasLibrary.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ define([
156156
{
157157
name: 'header',
158158
type: 'int',
159-
label: 'Header'
159+
label: 'Header',
160+
component: 'option_suggest',
161+
options: ['None', '0']
160162
},
161163
{
162164
name: 'sep',
@@ -2897,6 +2899,7 @@ define([
28972899
name: 'orient',
28982900
type: 'text',
28992901
label: 'JSON Orient',
2902+
component: 'option_select',
29002903
options: ['split', 'records', 'index', 'columns', 'values', 'table'],
29012904
default: 'columns' // if typ==series, index is default
29022905
},
@@ -2955,6 +2958,7 @@ define([
29552958
name: 'orient',
29562959
type: 'text',
29572960
label: 'Orient',
2961+
component: 'option_select',
29582962
// options: series 0~3 / dataframe *
29592963
options: ['split', 'records', 'index', 'table', 'columns', 'values']
29602964
}

js/com/com_generator.js

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ define([
150150
});
151151
// if required, no default option
152152
if (required != true) {
153-
$(optSlct).append($('<option value="">Default</option>'));
153+
$(optSlct).append($('<option value="">Select option...</option>'));
154154
}
155155
obj.options.forEach((opt, idx, arr) => {
156156
var label = (obj.options_label != undefined? obj.options_label[idx]:opt);
@@ -175,6 +175,27 @@ define([
175175
});
176176
tblInput.appendChild(optSlct);
177177
break;
178+
case 'option_suggest':
179+
// suggest input tag
180+
// 1. Target Variable
181+
var suggestInput = new SuggestInput();
182+
suggestInput.setComponentID(obj.name);
183+
suggestInput.addClass('vp-input vp-state');
184+
suggestInput.setSuggestList(function() { return obj.options; });
185+
suggestInput.setNormalFilter(obj.useFilter == undefined?false:obj.useFilter);
186+
suggestInput.setValue(obj.value);
187+
if (obj.placeholder != undefined) {
188+
suggestInput.setPlaceholder(obj.placeholder);
189+
} else {
190+
suggestInput.setPlaceholder('Type or Select value');
191+
}
192+
suggestInput.setSelectEvent(function(selectedValue) {
193+
// trigger change
194+
$(pageThis.wrapSelector('#' + obj.name)).val(selectedValue);
195+
$(pageThis.wrapSelector('#' + obj.name)).trigger('change');
196+
});
197+
tblInput.appendChild($(suggestInput.toTagString())[0]);
198+
break;
178199
case 'var_select':
179200
// suggest input tag
180201
var tag = document.createElement('input');
@@ -386,7 +407,7 @@ define([
386407
case 'option_select':
387408
var input = $(vp_wrapSelector(pageId, '#'+obj.name)).val();
388409
// same as default
389-
if (input == obj.default) break;
410+
// if (input == obj.default) break;
390411
value = input;
391412
break;
392413
case 'var_select':
@@ -400,6 +421,7 @@ define([
400421
break;
401422
case 'table':
402423
case 'file':
424+
case 'option_suggest':
403425
default:
404426
var input = $(vp_wrapSelector(pageId, '#'+obj.name)).val();
405427
// same as default

0 commit comments

Comments
 (0)