Skip to content

Commit 91987c5

Browse files
author
minjk-bl
committed
Edit File app's label
1 parent fc81f6a commit 91987c5

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

visualpython/html/m_apps/file.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
</thead>
6161
<tbody>
6262
<tr>
63-
<td><label for="vp_sampleFile" class="vp-orange-text">Sample Data</label></td>
63+
<td><label for="vp_sampleFile" class="vp-bold vp-orange-text">Sample Data</label></td>
6464
<td>
6565
<select class="vp-select option-select" id="vp_sampleFile">
6666
<option name="vp_sampleFile" value="iris.csv">iris</option>

visualpython/js/m_apps/File.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,11 @@ define([
213213
if (value === 'spss') {
214214
// show install button
215215
that.showInstallButton();
216+
// show install note below File type selection
217+
$(`<tr><td colspan="2">
218+
<label class="vp-orange-text vp-italic">NOTE: </label>
219+
<label class="vp-gray-text vp-italic">pyreadstat package is required to read spss file.</label>
220+
</td></tr>`).insertAfter($(that.wrapSelector('#fileType')).closest('tr'));
216221
} else {
217222
that.hideInstallButton();
218223
}
@@ -327,6 +332,13 @@ define([
327332
this.fileResultState = {
328333
...this.fileState[pageType].fileResultState
329334
};
335+
336+
if (selectedType == 'pickle') {
337+
// hide additional option box
338+
$(this.wrapSelector(prefix + '#vp_optionBox')).closest('.vp-accordian-container').hide();
339+
} else {
340+
$(this.wrapSelector(prefix + '#vp_optionBox')).closest('.vp-accordian-container').show();
341+
}
330342

331343
if (pageType == 'Write') {
332344
if (selectedType == 'json') {
@@ -344,7 +356,7 @@ define([
344356

345357
// prepend file type selector
346358
$(this.wrapSelector(prefix + '#vp_inputOutputBox table tbody')).prepend(
347-
$('<tr>').append($(`<td><label for="fileType" class="vp-orange-text">File Type</label></td>`))
359+
$('<tr>').append($(`<td><label for="fileType" class="vp-bold vp-orange-text">File Type</label></td>`))
348360
.append($('<td><select id="fileType" class="vp-select"></select></td>'))
349361
);
350362
var fileTypeList = Object.keys(fileTypeObj);
@@ -408,8 +420,6 @@ define([
408420
suggestInput.setPlaceholder('encoding option');
409421
return suggestInput.toTagString();
410422
});
411-
412-
413423
}
414424

415425
render() {

0 commit comments

Comments
 (0)