Skip to content

Commit 963a112

Browse files
author
minjk-bl
committed
Edit to show to_frame option when size() selected
1 parent 1403bab commit 963a112

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

visualpython/js/m_apps/Groupby.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ define([
177177
var colList = event.dataList;
178178
that.state.display = colList;
179179

180-
if (colList && colList.length == 1) {
180+
if ((colList && colList.length == 1) || that.state.method === 'size') {
181181
$(that.wrapSelector('#vp_gbToFrame')).parent().show();
182182
} else {
183183
$(that.wrapSelector('#vp_gbToFrame')).parent().hide();
@@ -196,6 +196,12 @@ define([
196196
var method = $(this).val();
197197
that.state.method = method;
198198
$(that.wrapSelector('#vp_gbMethod')).val(method);
199+
200+
if (method === 'size' || (that.state.display && that.state.display.length == 1)) {
201+
$(that.wrapSelector('#vp_gbToFrame')).parent().show();
202+
} else {
203+
$(that.wrapSelector('#vp_gbToFrame')).parent().hide();
204+
}
199205
});
200206

201207
// advanced checkbox event
@@ -744,7 +750,7 @@ define([
744750
// Display columns
745751
//====================================================================
746752
var colStr = '';
747-
if (display) {
753+
if (display && display.length > 0) {
748754
if (toFrame || display.length > 1) {
749755
// over 2 columns
750756
colStr = '[[' + display.join(',') + ']]';
@@ -891,6 +897,10 @@ define([
891897
methodStr.appendFormat('{0}(numeric_only=True)', method);
892898
} else {
893899
methodStr.appendFormat('{0}()', method);
900+
if (method === 'size' && toFrame === true) {
901+
// if to_Frame on size() method
902+
methodStr.append(".to_frame(name='size')");
903+
}
894904
}
895905
}
896906
}

0 commit comments

Comments
 (0)