Skip to content

Commit a33b8d3

Browse files
author
minjk-bl
committed
bug fix
1 parent b86fe44 commit a33b8d3

File tree

3 files changed

+22
-14
lines changed

3 files changed

+22
-14
lines changed

data/m_library/numpyLibrary.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1864,7 +1864,7 @@ define([
18641864
"name": "equal",
18651865
"library": "numpy",
18661866
"description": "",
1867-
"code": "${o0} = np.equal(${i0}, ${i1}${dtype})",
1867+
"code": "${o0} = np.equal(${i0}, ${i1})",
18681868
"options": [
18691869
{
18701870
"name": "i0",
@@ -1899,7 +1899,7 @@ define([
18991899
"name": "greater",
19001900
"library": "numpy",
19011901
"description": "",
1902-
"code": "${o0} = np.greater(${i0}, ${i1}${dtype})",
1902+
"code": "${o0} = np.greater(${i0}, ${i1})",
19031903
"options": [
19041904
{
19051905
"name": "i0",
@@ -1934,7 +1934,7 @@ define([
19341934
"name": "greater_equal",
19351935
"library": "numpy",
19361936
"description": "",
1937-
"code": "${o0} = np.greater_equal(${i0}, ${i1}${dtype})",
1937+
"code": "${o0} = np.greater_equal(${i0}, ${i1})",
19381938
"options": [
19391939
{
19401940
"name": "i0",
@@ -1969,7 +1969,7 @@ define([
19691969
"name": "less",
19701970
"library": "numpy",
19711971
"description": "",
1972-
"code": "${o0} = np.less(${i0}, ${i1}${dtype})",
1972+
"code": "${o0} = np.less(${i0}, ${i1})",
19731973
"options": [
19741974
{
19751975
"name": "i0",
@@ -2004,7 +2004,7 @@ define([
20042004
"name": "less_equal",
20052005
"library": "numpy",
20062006
"description": "",
2007-
"code": "${o0} = np.less_equal(${i0}, ${i1}${dtype})",
2007+
"code": "${o0} = np.less_equal(${i0}, ${i1})",
20082008
"options": [
20092009
{
20102010
"name": "i0",

js/com/com_generatorV2.js

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ define([
3838
}
3939

4040
const _VP_NP_DTYPES = [
41+
{
42+
name: 'Default',
43+
value: ''
44+
},
4145
{
4246
name: 'None',
4347
value: 'None'
@@ -185,7 +189,7 @@ define([
185189
}
186190
// render content
187191
let contentTag = $('<div class="vp-auto-component-content"></div>');
188-
contentTag.append(renderContent(pageThis, componentType, obj, value, state));
192+
contentTag.append(renderContent(pageThis, componentType, obj, state));
189193
tblContent.append(contentTag);
190194

191195
tblRow.append(tblLabel);
@@ -489,7 +493,7 @@ define([
489493
try {
490494
package.options && package.options.forEach(function(v, i) {
491495
var val = state[v.name];
492-
if (val == undefined) {
496+
if (val == undefined || val == '') {
493497
val = vp_getTagValue(pageThis, v);
494498
}
495499
var id = '${' + v.name + '}';
@@ -847,15 +851,15 @@ define([
847851
if (obj.placeholder) {
848852
placeholder = obj.placeholder;
849853
}
850-
return $(`<input class="vp-input vp-state" placeholder="${placeholder}" value="${state[obj.name]}"/>`);
854+
return $(`<input class="vp-input vp-state" id="${obj.name}" placeholder="${placeholder}" value="${state[obj.name]}"/>`);
851855
}
852856

853857
var renderParam = function(pageThis, obj, defaultValue) {
854858
let placeholder = 'Input Param';
855859
if (obj.placeholder) {
856860
placeholder = obj.placeholder;
857861
}
858-
return $(`<input class="vp-input vp-state" placeholder="${placeholder}" value="${state[obj.name]}"/>`);
862+
return $(`<input class="vp-input vp-state" id="${obj.name}" placeholder="${placeholder}" value="${state[obj.name]}"/>`);
859863
}
860864

861865
var renderDtypeSelector = function(pageThis, obj, defaultValue) {
@@ -889,8 +893,6 @@ define([
889893
let contentTag = $(this).parent().find('.vp-auto-component-content');
890894
let newType = $(this).val();
891895
let obj = $(this).data('obj');
892-
// reset state
893-
pageThis.setState({ [obj.name]: '' });
894896
$(contentTag).html(renderContent(pageThis, newType, obj, pageThis.getState()));
895897
});
896898

@@ -992,7 +994,10 @@ define([
992994
let row = $(this).parent().find('.vp-numpy-2darr-set-row').val();
993995
let col = $(this).parent().find('.vp-numpy-2darr-set-col').val();
994996
// update state
995-
let state = Array(parseInt(row)).fill(Array(parseInt(col)).fill(0));
997+
let state = Array(parseInt(row));
998+
for (let i = 0; i < state.length; i++) {
999+
state[i] = Array(parseInt(col)).fill(0);
1000+
}
9961001
pageThis.setState({ [arrId]: state });
9971002
pageThis.setState({ [id]: `[${state.map(ele => '[' + ele.join(',') + ']').join(',')}]` });
9981003
// re-render
@@ -1060,7 +1065,10 @@ define([
10601065
// update state
10611066
let state = pageThis.getState(arrId);
10621067
if (!state) {
1063-
state = Array(rowIdx + 1).fill([]);
1068+
state = Array(rowIdx + 1);
1069+
for (let i = 0; i < state.length; i++) {
1070+
state[i] = [];
1071+
}
10641072
}
10651073
state[rowIdx].push(0);
10661074
pageThis.setState({ [arrId]: state });

js/com/component/NumpyComponent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ define([
129129
super.render();
130130

131131
// show interface
132-
com_generatorV2.vp_showInterfaceOnPage(this, this.package);
132+
com_generatorV2.vp_showInterfaceOnPage(this, this.package, this.state);
133133

134134
// hide optional page if no options
135135
if ($.trim($(this.wrapSelector('#vp_optionBox table tbody')).html())=='') {

0 commit comments

Comments
 (0)