Skip to content

Commit a908e4a

Browse files
author
minjk-bl
committed
Edit VarSelector to DataSelector on Fit/Predict and ModelInfo app
1 parent 8625224 commit a908e4a

File tree

4 files changed

+70
-89
lines changed

4 files changed

+70
-89
lines changed

js/com/com_generatorV2.js

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@ define([
1212
'vp_base/js/com/com_util',
1313
'vp_base/js/com/com_makeDom',
1414
'vp_base/js/com/component/SuggestInput',
15-
'vp_base/js/com/component/VarSelector2'
16-
], function (com_util, com_makeDom, SuggestInput, VarSelector2) {
15+
'vp_base/js/com/component/VarSelector2',
16+
'vp_base/js/com/component/DataSelector'
17+
], function (com_util, com_makeDom, SuggestInput, VarSelector2, DataSelector) {
1718
/**
1819
* show result after code executed
1920
*/
@@ -33,6 +34,7 @@ define([
3334
'bool_select': 'Select Boolean',
3435
'option_select': 'Select option',
3536
'option_suggest': 'Input option',
37+
'data_select': 'Select data',
3638
'var_select': 'Select Variable',
3739
'var_multi': 'Select N-Variables',
3840
'col_select': 'Select Column',
@@ -346,6 +348,16 @@ define([
346348
});
347349
content = $(suggestInput.toTagString());
348350
break;
351+
case 'data_select':
352+
let dataSelector = new DataSelector({
353+
pageThis: pageThis,
354+
id: obj.name,
355+
allowDataType: obj.var_type,
356+
placeholder: obj.placeholder || 'Select data',
357+
value: value
358+
});
359+
content = $(dataSelector.toTagString());
360+
break;
349361
case 'var_select':
350362
// suggest input tag
351363
var tag = $('<input/>').attr({
@@ -583,6 +595,7 @@ define([
583595
break;
584596
case 'input_multi':
585597
case 'bool_select':
598+
case 'data_select':
586599
case 'var_select':
587600
case 'var_multi':
588601
case 'col_select':

js/com/component/DataSelector.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ define([
4949
type: 'data', // selector type : data / column
5050
pageThis: null, // target's page object
5151
id: '', // target id
52+
value: null, // pre-defined value
5253
finish: null, // callback after selection
5354
select: null, // callback after selection from suggestInput
5455
allowDataType: ['DataFrame', 'Series', 'ndarray', 'list', 'dict'], // default allow data types
@@ -331,9 +332,13 @@ define([
331332
}
332333

333334
templateForTarget() {
335+
let value = this.prop.value;
336+
if (value == undefined) {
337+
value = this.prop.pageThis.state[this.prop.id] || '';
338+
}
334339
return `
335340
<div class="vp-ds-box vp-ds-box-${this.uuid} vp-ds-uninit">
336-
<input type="text" class="vp-ds-target vp-input vp-state ${this.prop.classes}" id="${this.prop.id}" value="${this.prop.pageThis.state[this.prop.id]}" placeholder="${this.prop.placeholder}"/>
341+
<input type="text" class="vp-ds-target vp-input vp-state ${this.prop.classes}" id="${this.prop.id}" value="${value}" placeholder="${this.prop.placeholder}"/>
337342
<span class="vp-ds-filter"><img src="/nbextensions/visualpython/img/filter.svg"/></span>
338343
</div>
339344
`;

0 commit comments

Comments
 (0)