Skip to content

Commit b136d12

Browse files
author
minjk-bl
committed
Edit Frame, Subset app to support DataSelector on allocating variable
1 parent fce2b63 commit b136d12

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

visualpython/js/m_apps/Frame.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ define([
2020
'vp_base/js/com/com_util',
2121
'vp_base/js/com/component/PopupComponent',
2222
'vp_base/js/com/component/SuggestInput',
23-
'vp_base/js/com/component/VarSelector',
23+
'vp_base/js/com/component/DataSelector',
2424
'vp_base/js/m_apps/Subset'
25-
], function(frameHtml, frameCss, com_Const, com_String, com_util, PopupComponent, SuggestInput, VarSelector, Subset) {
25+
], function(frameHtml, frameCss, com_Const, com_String, com_util, PopupComponent, SuggestInput, DataSelector, Subset) {
2626

2727
/**
2828
* Frame
@@ -516,7 +516,14 @@ define([
516516
}
517517

518518
templateForBody() {
519-
return frameHtml;
519+
let page = $(frameHtml);
520+
521+
let allocateSelector = new DataSelector({
522+
pageThis: this, id: 'vp_feReturn', placeholder: 'Variable name', required: true, value: '_vp'
523+
});
524+
$(page).find('#vp_feReturn').replaceWith(allocateSelector.toTagString());
525+
526+
return page;
520527
}
521528

522529
render() {

visualpython/js/m_apps/Subset.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ define([
2121
'vp_base/js/com/component/PopupComponent',
2222
'vp_base/js/com/component/SuggestInput',
2323
'vp_base/js/com/component/VarSelector',
24-
'vp_base/js/com/component/MultiSelector'
25-
], function(subsetHtml, subsetCss, com_Const, com_String, com_util, PopupComponent, SuggestInput, VarSelector, MultiSelector) {
24+
'vp_base/js/com/component/DataSelector'
25+
], function(subsetHtml, subsetCss, com_Const, com_String, com_util, PopupComponent, SuggestInput, VarSelector, DataSelector) {
2626

2727
/**
2828
* Subset
@@ -142,7 +142,18 @@ define([
142142
}
143143

144144
templateForBody() {
145-
return subsetHtml;
145+
let page = $(subsetHtml);
146+
147+
let that = this;
148+
let allocateSelector = new DataSelector({
149+
pageThis: this, id: 'allocateTo', classes: VP_DS_ALLOCATE_TO, placeholder: 'New variable name', required: true,
150+
finish: function() {
151+
that.generateCode();
152+
}
153+
});
154+
$(page).find('.' + VP_DS_ALLOCATE_TO).replaceWith(allocateSelector.toTagString());
155+
156+
return page;
146157
}
147158
templateForDataView() {
148159
let tag = new com_String();

0 commit comments

Comments
 (0)