Skip to content

Commit b3de85b

Browse files
author
minjk-bl
committed
Popup - change maximize icon
1 parent 57cbf99 commit b3de85b

File tree

7 files changed

+17
-18
lines changed

7 files changed

+17
-18
lines changed

css/popupComponent.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,9 @@
119119
padding: 15px;
120120
overflow: auto;
121121
}
122+
.vp-popup-content {
123+
min-height: calc(100% - 30px);
124+
}
122125
.vp-popup-footer {
123126
position: relative;
124127
height: 50px;

html/popupComponent.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646
<!-- Title -->
4747
</label>
4848
<img class="vp-popup-toggle" src="/nbextensions/visualpython/img/minimize.svg" title="Minimize this popup">
49-
<img class="vp-popup-maximize" src="/nbextensions/visualpython/img/maximize.svg" title="Maximize this popup">
50-
<img class="vp-popup-return" src="/nbextensions/visualpython/img/returnSize.svg" title="Return size of this popup">
49+
<img class="vp-popup-maximize" src="/nbextensions/visualpython/img/max_window.svg" title="Maximize this popup">
50+
<img class="vp-popup-return" src="/nbextensions/visualpython/img/min_window.svg" title="Return size of this popup">
5151
<img class="vp-popup-close" src="/nbextensions/visualpython/img/close_big.svg" title="Close popup"/>
5252
</div>
5353
<div class="vp-popup-body vp-scrollbar">

img/max_window.svg

Lines changed: 3 additions & 0 deletions
Loading

img/maximize.svg

Lines changed: 0 additions & 6 deletions
This file was deleted.

img/min_window.svg

Lines changed: 4 additions & 0 deletions
Loading

img/returnSize.svg

Lines changed: 0 additions & 10 deletions
This file was deleted.

js/com/component/PopupComponent.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,11 @@ define([
260260
$(this.wrapSelector('.vp-popup-maximize')).on('click', function(evt) {
261261
// save position
262262
that.config.position = $(that.wrapSelector()).position();
263+
// save size
264+
that.config.size = {
265+
width: $(that.wrapSelector()).width(),
266+
height: $(that.wrapSelector()).height()
267+
}
263268
// maximize popup
264269
$(that.wrapSelector()).css({
265270
width: '100%',

0 commit comments

Comments
 (0)