Skip to content

Commit c48a0b7

Browse files
author
minjk-bl
committed
Edit Bind and Reshape to control drop option of reset_index
1 parent be1c3a6 commit c48a0b7

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

visualpython/html/m_apps/bind.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
<label for="vp_bdAllocateTo" class="w100">Allocate to</label>
9292
<input type="text" id="vp_bdAllocateTo" placeholder="New variable name">
9393
<label><input type="checkbox" id="vp_bdResetIndex"><span>Reset Index</span></label>
94-
<select id="vp_bdWithoutColumn" class="vp-select" style="width: 130px;">
94+
<select id="vp_bdWithoutColumn" class="vp-select" style="width: 130px;" disabled>
9595
<option value="True" selected>Without column</option>
9696
<option value="">With column</option>
9797
</select>

visualpython/html/m_apps/reshape.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
<label for="vp_rsAllocateTo" class="w100">Allocate to</label>
8080
<input type="text" id="vp_rsAllocateTo" placeholder="New variable name">
8181
<label><input type="checkbox" id="vp_rsResetIndex"><span>Reset Index</span></label>
82-
<select id="vp_rsWithoutColumn" class="vp-select" style="width: 130px;">
82+
<select id="vp_rsWithoutColumn" class="vp-select" style="width: 130px;" disabled>
8383
<option value="True" selected>Without column</option>
8484
<option value="">With column</option>
8585
</select>

visualpython/js/m_apps/Bind.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,9 @@ define([
308308

309309
// reset index checkbox event
310310
$(document).on('change', this.wrapSelector('#vp_bdResetIndex'), function() {
311-
that.state.resetIndex = $(this).prop('checked');
311+
let isChecked = $(this).prop('checked');
312+
$(that.wrapSelector('#vp_bdWithoutColumn')).prop('disabled', !isChecked);
313+
that.state.resetIndex = isChecked;
312314
});
313315

314316
// with/without column select event
@@ -334,7 +336,7 @@ define([
334336

335337
renderDataPage(renderedText, isHtml = true) {
336338
var tag = new com_String();
337-
tag.appendFormatLine('<div class="{0} vp-close-on-blur vp-scrollbar">', 'rendered_html'); // 'rendered_html' style from jupyter output area
339+
tag.appendFormatLine('<div class="{0} vp-close-on-blur vp-scrollbar">', 'vp_rendered_html'); // 'rendered_html' style from jupyter output area
338340
if (isHtml) {
339341
tag.appendLine(renderedText);
340342
} else {

visualpython/js/m_apps/Reshape.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,9 @@ define([
219219

220220
// reset index checkbox event
221221
$(document).on('change', this.wrapSelector('#vp_rsResetIndex'), function() {
222-
that.state.resetIndex = $(this).prop('checked');
222+
let isChecked = $(this).prop('checked');
223+
$(that.wrapSelector('#vp_rsWithoutColumn')).prop('disabled', !isChecked);
224+
that.state.resetIndex = isChecked;
223225
});
224226

225227
// with/without column select event
@@ -246,7 +248,7 @@ define([
246248

247249
renderDataPage(renderedText, isHtml = true) {
248250
var tag = new com_String();
249-
tag.appendFormatLine('<div class="{0} vp-close-on-blur vp-scrollbar">', 'rendered_html'); // 'rendered_html' style from jupyter output area
251+
tag.appendFormatLine('<div class="{0} vp-close-on-blur vp-scrollbar">', 'vp_rendered_html'); // 'rendered_html' style from jupyter output area
250252
if (isHtml) {
251253
tag.appendLine(renderedText);
252254
} else {

0 commit comments

Comments
 (0)