Skip to content

Add 'Comment Template' to comment logic block. #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Minku-Koo opened this issue Aug 2, 2022 · 3 comments
Closed

Add 'Comment Template' to comment logic block. #155

Minku-Koo opened this issue Aug 2, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Minku-Koo
Copy link
Contributor

Add 'Comment Template' to comment logic block.

[Original]

  • Only comment beginning with # is provided.

[Improved]

  • Provides 'comment template' functionality applicable to Python Class and Method.
  • You can add a new template easily.
  • 'Comment Templates' are referenced in the Numpy Style Guide.
  • Reference Document 1
  • Reference Document 2

Why Numpy Style Guide?

  • Visual Python has many features for Data Analysis and Machine Learning.
  • The Numpy Library is most often used in Data Analysis and ML.

A new function is included in .gif image.

comment_template_clip

I want feedback.

thank you.
@Minku-Koo Minku-Koo added the enhancement New feature or request label Aug 2, 2022
Minku-Koo added a commit to Minku-Koo/visualpython that referenced this issue Aug 3, 2022
@Minku-Koo
visualpython#155 - Add 'Comment Template' to comment logic block.
05dc7f7 
add comment template function on comment logic block
@minjk-bl minjk-bl added the need reply Need developer's reply label Aug 5, 2022
@minjk-bl
Copy link
Collaborator

minjk-bl commented Apr 3, 2023

Hello @Minku-Koo ,
Thank you for suggesting your idea. It would be great if it is applied to our project.
I'll wait for your pull-request to apply this idea.

@minjk-bl minjk-bl removed the need reply Need developer's reply label Apr 3, 2023
Minku-Koo added a commit to Minku-Koo/visualpython that referenced this issue Apr 3, 2023
@Minku-Koo
Fixed visualpython#155 - Add 'Comment Template' to comment logic block.
618c361 
- Add comment templates consisting of default, class and method
@Minku-Koo
Copy link
Contributor Author

These changes have a history of creating PR on the 'os_library' branch.

Is it ok to create PR for the same changes in the 'release' branch?

@minjk-bl
Copy link
Collaborator

minjk-bl commented Apr 4, 2023

oss_library branch is not matching with the current structure, so it would be great if you can make PR in the devops branch!

  • release branch is only used for releasing new version. For developing purpose, you can use devops branch to create pull-request.

Minku-Koo added a commit to Minku-Koo/visualpython that referenced this issue Apr 4, 2023
@Minku-Koo
Fixed visualpython#155 - Add 'Comment Template' to comment logic block.
3412cee 
- Add comment templates consisting of default, class and method
Minku-Koo added a commit to Minku-Koo/visualpython that referenced this issue Apr 4, 2023
@Minku-Koo
Merge pull request #1 from Minku-Koo/koo
7188bd6 
Fixed visualpython#155 - Add 'Comment Template' to comment logic block.
Minku-Koo added a commit to Minku-Koo/visualpython that referenced this issue Apr 4, 2023
@Minku-Koo
Revert "Fixed visualpython#155 - Add 'Comment Template' to comment lo…
46606f6 
…gic block. "
Minku-Koo added a commit to Minku-Koo/visualpython that referenced this issue Apr 4, 2023
@Minku-Koo
Merge pull request #2 from Minku-Koo/revert-1-koo
d77ea47 
Revert "Fixed visualpython#155 - Add 'Comment Template' to comment logic block. "
Minku-Koo added a commit to Minku-Koo/visualpython that referenced this issue Apr 4, 2023
@Minku-Koo
Fixed visualpython#155 - Add 'Comment Template' to comment logic block.
334d77e 
Add comment template on logic block
Templates are consisting of default, class and method
Minku-Koo added a commit to Minku-Koo/visualpython that referenced this issue Apr 7, 2023
@Minku-Koo
Fixed visualpython#155 - Add 'Comment Template' to comment logic block.
53629d5 
- Add comment template on logic block
- Templates are consisting of default, class and method
minjk-bl added a commit that referenced this issue Apr 10, 2023
@minjk-bl
Merge pull request #211 from Minku-Koo/devkoo
d5dacbb 
Fixed #155 - Add 'Comment Template' to comment logic block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Minku-Koo @minjk-bl