Merge pull request Sub6Resources#523 from tneotia/bugfix/gif-completer-issue

ryan-berger · web-flow · commit 048a00a189ca · 2021-02-03T16:12:44.000-07:00
Fix completer.complete() firing multiple times when rendering GIFs
diff --git a/lib/src/replaced_element.dart b/lib/src/replaced_element.dart
@@ -133,7 +133,9 @@ class ImageContentElement extends ReplacedElement {
       Completer<Size> completer = Completer();
       Image image = Image.network(src, frameBuilder: (ctx, child, frame, _) {
         if (frame == null) {
-          completer.completeError("error");
+          if (!completer.isCompleted) {
+            completer.completeError("error");
+          }
           return child;
         } else {
           return child;
@@ -142,11 +144,14 @@ class ImageContentElement extends ReplacedElement {
       image.image.resolve(ImageConfiguration()).addListener(
             ImageStreamListener((ImageInfo image, bool synchronousCall) {
               var myImage = image.image;
-              Size size =
-                  Size(myImage.width.toDouble(), myImage.height.toDouble());
-              completer.complete(size);
+              Size size = Size(myImage.width.toDouble(), myImage.height.toDouble());
+              if (!completer.isCompleted) {
+                completer.complete(size);
+              }
             }, onError: (object, stacktrace) {
-              completer.completeError(object);
+              if (!completer.isCompleted) {
+                completer.completeError(object);
+              }
             }),
           );
       imageWidget = FutureBuilder<Size>(
