Merge pull request Sub6Resources#934 from EA-YOUHOU/Fix/a-tag-no-href

tneotia · web-flow · commit 6de34b9242c7 · 2021-12-09T20:36:44.000-05:00
Disable click effect and decoration when a tag have no href attribute
diff --git a/lib/src/interactable_element.dart b/lib/src/interactable_element.dart
@@ -22,20 +22,30 @@ enum Gesture {
   TAP,
 }
 
-InteractableElement parseInteractableElement(
+StyledElement parseInteractableElement(
     dom.Element element, List<StyledElement> children) {
   switch (element.localName) {
     case "a":
-      return InteractableElement(
+      if (element.attributes.containsKey('href')) {
+        return InteractableElement(
+            name: element.localName!,
+            children: children,
+            href: element.attributes['href'],
+            style: Style(
+              color: Colors.blue,
+              textDecoration: TextDecoration.underline,
+            ),
+            node: element,
+            elementId: element.id
+        );
+      }
+      // When <a> tag have no href, it must be non clickable and without decoration.
+      return StyledElement(
         name: element.localName!,
         children: children,
-        href: element.attributes['href'],
-        style: Style(
-          color: Colors.blue,
-          textDecoration: TextDecoration.underline,
-        ),
+        style: Style(),
         node: element,
-        elementId: element.id
+        elementId: element.id,
       );
     /// will never be called, just to suppress missing return warning
     default:
@@ -48,4 +58,4 @@ InteractableElement parseInteractableElement(
         elementId: "[[No ID]]"
       );
   }
-}
+}
