From 4f4ab01f70068261a341e0b45940c85c6b176e67 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 07:11:06 +0300 Subject: [PATCH 01/15] added publish CI --- .github/workflows/build.yml | 16 ++++++++++--- .github/workflows/deploy-pre-release.yml | 30 ++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 3 deletions(-) create mode 100644 .github/workflows/deploy-pre-release.yml diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b0dea47b..f1c41ddd 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,7 +1,7 @@ # Copyright (c) Microsoft Corporation. # Licensed under the MIT License. -name: CI +name: Build CI on: push: @@ -12,14 +12,24 @@ on: pull_request: branches: - main + workflow_call: + inputs: + BUILD_FLAGS: + description: 'additional build flags to pass to build' + default: '' + required: false + type: string jobs: build: + env: + BUILD_FLAGS: ${{ inputs.BUILD_FLAGS }} runs-on: ${{ matrix.os }} strategy: fail-fast: false matrix: os: [ ubuntu-latest, macos-latest, windows-latest ] + steps: - name: Checkout @@ -82,12 +92,12 @@ jobs: if: ${{ matrix.os != 'windows-latest' }} run: | export NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" - node build/package.js + node build/package.js ${{ BUILD_FLAGS }} - name: Build and pack extension (windows) if: ${{ matrix.os == 'windows-latest' }} run: | $env:NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" - node build/package.js + node build/package.js ${{ BUILD_FLAGS }} - name: Publish extension VSIX as artifact uses: actions/upload-artifact@v2 with: diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml new file mode 100644 index 00000000..b4bd4f51 --- /dev/null +++ b/.github/workflows/deploy-pre-release.yml @@ -0,0 +1,30 @@ +name: Publish pre-release extension to + +on: + push: + branches: + - master + +jobs: + build-and-publish: + runs-on: ubuntu-latest + steps: + - name: build + uses: ./.github/workflows/build.yml + with: + BUILD_FLAGS: '--pre-release' + + - name: download-artifacts + uses: actions/download-artifact@v4 + with: + name: VS Code extension VSIXes (ubuntu-latest) + + - name: upload extension + run: | + echo ${{ secrets.VSCE_PASSWORD }} | vsce login ${{ secrets.VSCE_USER }} + vsce publish --pre-release --packagePath ./out/vsix/* + vsce logout + + + + From bed144d90b6a00358c09305624c972c14c594636 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 09:31:47 +0300 Subject: [PATCH 02/15] typo fix --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f1c41ddd..7f7794e2 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -92,12 +92,12 @@ jobs: if: ${{ matrix.os != 'windows-latest' }} run: | export NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" - node build/package.js ${{ BUILD_FLAGS }} + node build/package.js ${{ env.BUILD_FLAGS }} - name: Build and pack extension (windows) if: ${{ matrix.os == 'windows-latest' }} run: | $env:NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" - node build/package.js ${{ BUILD_FLAGS }} + node build/package.js ${{ env.BUILD_FLAGS }} - name: Publish extension VSIX as artifact uses: actions/upload-artifact@v2 with: From 0a252bc8b0529263dc6427d9cb67b9252180abe4 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 09:35:38 +0300 Subject: [PATCH 03/15] test deploy one time --- .github/workflows/deploy-pre-release.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index b4bd4f51..54fbf74e 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -4,6 +4,10 @@ on: push: branches: - master + pull_request: + branches: + - main + workflow_dispatch: jobs: build-and-publish: From 0a3930f3718b930094aec41852ed03d0bd05a675 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 09:37:14 +0300 Subject: [PATCH 04/15] forgot checkout --- .github/workflows/deploy-pre-release.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index 54fbf74e..2dfc4855 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -13,6 +13,9 @@ jobs: build-and-publish: runs-on: ubuntu-latest steps: + - name: Checkout + uses: actions/checkout@v3 + - name: build uses: ./.github/workflows/build.yml with: From db922352c3186d6e973d41fefc3632d5ac5a67b5 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 09:46:07 +0300 Subject: [PATCH 05/15] fixed workflow --- .github/workflows/deploy-pre-release.yml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index 2dfc4855..3c5064a0 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -10,16 +10,15 @@ on: workflow_dispatch: jobs: - build-and-publish: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v3 + call-build: + uses: ./.github/workflows/build.yml + with: + BUILD_FLAGS: '--pre-release' - - name: build - uses: ./.github/workflows/build.yml - with: - BUILD_FLAGS: '--pre-release' + upload: + needs: call-build + runs-on: ubuntu-latest + steps: - name: download-artifacts uses: actions/download-artifact@v4 From 690ed38945a9512986085d978f5bcc8804800729 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 09:53:53 +0300 Subject: [PATCH 06/15] test --- .github/workflows/build.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7f7794e2..feececb4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -19,6 +19,16 @@ on: default: '' required: false type: string + os: + description: os to use in the run + type: choice + options: + - '["ubuntu-latest"]' + - '["windows-latest"]' + - '["macos-latest"]' + - '["ubuntu-latest", "macos-latest", "windows-latest"]' + default: '["ubuntu-latest", "macos-latest", "windows-latest"]' + required: true jobs: build: @@ -28,7 +38,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ ubuntu-latest, macos-latest, windows-latest ] + os: ${{ fromJson(inputs.os) }} # [ ubuntu-latest, macos-latest, windows-latest ] steps: From f56bb70fbcd06f28732d71a8d563fe13340bae06 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 09:58:48 +0300 Subject: [PATCH 07/15] test2 --- .github/workflows/build.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index feececb4..a457e574 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,12 +21,7 @@ on: type: string os: description: os to use in the run - type: choice - options: - - '["ubuntu-latest"]' - - '["windows-latest"]' - - '["macos-latest"]' - - '["ubuntu-latest", "macos-latest", "windows-latest"]' + type: string default: '["ubuntu-latest", "macos-latest", "windows-latest"]' required: true From 549b85caee74fa2aa814a1bfc16ce470fbc787cc Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 10:00:03 +0300 Subject: [PATCH 08/15] test3 --- .github/workflows/deploy-pre-release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index 3c5064a0..8cdb0689 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -14,6 +14,7 @@ jobs: uses: ./.github/workflows/build.yml with: BUILD_FLAGS: '--pre-release' + os: '["ubuntu-latest"]' upload: needs: call-build From b40373bfa5574f450e6bb7b790874c68cfdb3c68 Mon Sep 17 00:00:00 2001 From: Lior Date: Mon, 16 Sep 2024 19:07:55 +0300 Subject: [PATCH 09/15] test4 --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a457e574..b83addab 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -23,7 +23,7 @@ on: description: os to use in the run type: string default: '["ubuntu-latest", "macos-latest", "windows-latest"]' - required: true + required: false jobs: build: From d7c92e46803d3a2a302636bbc62a81dcd4c71e25 Mon Sep 17 00:00:00 2001 From: Lior Date: Mon, 16 Sep 2024 19:10:11 +0300 Subject: [PATCH 10/15] test5 --- .github/workflows/deploy-pre-release.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index 8cdb0689..e55299d4 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -20,11 +20,18 @@ jobs: needs: call-build runs-on: ubuntu-latest steps: - - name: download-artifacts uses: actions/download-artifact@v4 with: name: VS Code extension VSIXes (ubuntu-latest) + + - name: Use Node 18.x + uses: actions/setup-node@v2 + with: + node-version: 18.x + + - name: install vsce + run: npm install --global vsce - name: upload extension run: | From 315f6118ed7acbdf39bcf17c9ccc47a3a49ff471 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 22:45:56 +0300 Subject: [PATCH 11/15] trying something different --- .github/workflows/build.yml | 104 +--------------------- .github/workflows/deploy-pre-release.yml | 15 ++-- .github/workflows/templates/build.yml | 107 +++++++++++++++++++++++ 3 files changed, 118 insertions(+), 108 deletions(-) create mode 100644 .github/workflows/templates/build.yml diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b83addab..78e04fcd 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,8 +1,4 @@ -# Copyright (c) Microsoft Corporation. -# Licensed under the MIT License. - name: Build CI - on: push: branches: @@ -12,104 +8,8 @@ on: pull_request: branches: - main - workflow_call: - inputs: - BUILD_FLAGS: - description: 'additional build flags to pass to build' - default: '' - required: false - type: string - os: - description: os to use in the run - type: string - default: '["ubuntu-latest", "macos-latest", "windows-latest"]' - required: false jobs: build: - env: - BUILD_FLAGS: ${{ inputs.BUILD_FLAGS }} - runs-on: ${{ matrix.os }} - strategy: - fail-fast: false - matrix: - os: ${{ fromJson(inputs.os) }} # [ ubuntu-latest, macos-latest, windows-latest ] - - - steps: - - name: Checkout - uses: actions/checkout@v2 - - # Node 16 matches the version of Node used by VS Code when this was - # written, but it should be updated when VS Code updates its Node version. - # Node needs to be installed before OS-specific setup so that we can run - # the hash verification script. - - name: Use Node 18.x - uses: actions/setup-node@v2 - with: - node-version: 18.x - - # On new macos-latest machines, Python 3.9+ is used, and it's causing issues with binding.gyp - - name: Use Python 3.8 - if: ${{ matrix.os == 'macos-latest' }} - uses: actions/setup-python@v5 - with: - python-version: 3.8 - - - name: Windows setup - if: ${{ matrix.os == 'windows-latest' }} - run: | - curl -LO https://downloads.arduino.cc/arduino-1.8.19-windows.zip - node build/checkHash.js arduino-1.8.19-windows.zip ` - c704a821089eab2588f1deae775916219b1517febd1dd574ff29958dca873945 - 7z x arduino-1.8.19-windows.zip -o"$Env:TEMP\arduino-ide" - echo "$Env:TEMP\arduino-ide\arduino-1.8.19" | Out-File -FilePath $env:GITHUB_PATH -Append - - name: Linux setup - if: ${{ matrix.os == 'ubuntu-latest' }} - run: | - export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0 - sleep 3 - wget https://downloads.arduino.cc/arduino-1.8.19-linux64.tar.xz -P /home/$USER - node build/checkHash.js /home/$USER/arduino-1.8.19-linux64.tar.xz \ - eb68bddc1d1c0120be2fca1350a03ee34531cf37f51847b21210b6e70545bc9b - tar -xvf /home/$USER/arduino-1.8.19-linux64.tar.xz -C /home/$USER/ - sudo ln -s /home/$USER/arduino-1.8.19/arduino /usr/bin/arduino - sudo apt-get update - sudo apt-get install -y g++-multilib build-essential libudev-dev - - name: macOS setup - if: ${{ matrix.os == 'macos-latest' }} - run: | - /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)" - brew install arduino --cask - - # Windows agents already have gulp installed. - - name: Install gulp - if: ${{ matrix.os != 'windows-latest' }} - run: npm install --global gulp - - name: Install global dependencies - run: npm install --global node-gyp vsce - - name: Install project dependencies - run: npm install - - - name: Check for linting errors - run: gulp tslint - - name: Build and pack extension - if: ${{ matrix.os != 'windows-latest' }} - run: | - export NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" - node build/package.js ${{ env.BUILD_FLAGS }} - - name: Build and pack extension (windows) - if: ${{ matrix.os == 'windows-latest' }} - run: | - $env:NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" - node build/package.js ${{ env.BUILD_FLAGS }} - - name: Publish extension VSIX as artifact - uses: actions/upload-artifact@v2 - with: - name: VS Code extension VSIXes (${{ matrix.os }}) - path: out/vsix - - - name: Run tests - uses: GabrielBB/xvfb-action@v1 - with: - run: npm test --silent + uses: ./.github/workflows/templates/build.yml + \ No newline at end of file diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index e55299d4..c713fa91 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -11,7 +11,7 @@ on: jobs: call-build: - uses: ./.github/workflows/build.yml + uses: ./.github/workflows/template/build.yml with: BUILD_FLAGS: '--pre-release' os: '["ubuntu-latest"]' @@ -32,12 +32,15 @@ jobs: - name: install vsce run: npm install --global vsce + + - name: vsce login + run: echo ${{ secrets.VSCE_PASSWORD }} | vsce login ${{ secrets.VSCE_USER }} + + - name: publish extension + run: vsce publish --pre-release --packagePath ./out/vsix/* - - name: upload extension - run: | - echo ${{ secrets.VSCE_PASSWORD }} | vsce login ${{ secrets.VSCE_USER }} - vsce publish --pre-release --packagePath ./out/vsix/* - vsce logout + - name: vsce logout + run: vsce logout diff --git a/.github/workflows/templates/build.yml b/.github/workflows/templates/build.yml new file mode 100644 index 00000000..9e1053e5 --- /dev/null +++ b/.github/workflows/templates/build.yml @@ -0,0 +1,107 @@ +# Copyright (c) Microsoft Corporation. +# Licensed under the MIT License. + +name: Build CI Template + +on: + workflow_call: + inputs: + BUILD_FLAGS: + description: 'additional build flags to pass to build' + default: '' + required: false + type: string + os: + description: os to use in the run + type: string + default: '["ubuntu-latest", "macos-latest", "windows-latest"]' + required: false + +jobs: + build: + env: + BUILD_FLAGS: ${{ inputs.BUILD_FLAGS }} + runs-on: ${{ matrix.os }} + strategy: + fail-fast: false + matrix: + os: ${{ fromJson(inputs.os) }} + + + steps: + - name: Checkout + uses: actions/checkout@v2 + + # Node 16 matches the version of Node used by VS Code when this was + # written, but it should be updated when VS Code updates its Node version. + # Node needs to be installed before OS-specific setup so that we can run + # the hash verification script. + - name: Use Node 18.x + uses: actions/setup-node@v2 + with: + node-version: 18.x + + # On new macos-latest machines, Python 3.9+ is used, and it's causing issues with binding.gyp + - name: Use Python 3.8 + if: ${{ matrix.os == 'macos-latest' }} + uses: actions/setup-python@v5 + with: + python-version: 3.8 + + - name: Windows setup + if: ${{ matrix.os == 'windows-latest' }} + run: | + curl -LO https://downloads.arduino.cc/arduino-1.8.19-windows.zip + node build/checkHash.js arduino-1.8.19-windows.zip ` + c704a821089eab2588f1deae775916219b1517febd1dd574ff29958dca873945 + 7z x arduino-1.8.19-windows.zip -o"$Env:TEMP\arduino-ide" + echo "$Env:TEMP\arduino-ide\arduino-1.8.19" | Out-File -FilePath $env:GITHUB_PATH -Append + - name: Linux setup + if: ${{ matrix.os == 'ubuntu-latest' }} + run: | + export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0 + sleep 3 + wget https://downloads.arduino.cc/arduino-1.8.19-linux64.tar.xz -P /home/$USER + node build/checkHash.js /home/$USER/arduino-1.8.19-linux64.tar.xz \ + eb68bddc1d1c0120be2fca1350a03ee34531cf37f51847b21210b6e70545bc9b + tar -xvf /home/$USER/arduino-1.8.19-linux64.tar.xz -C /home/$USER/ + sudo ln -s /home/$USER/arduino-1.8.19/arduino /usr/bin/arduino + sudo apt-get update + sudo apt-get install -y g++-multilib build-essential libudev-dev + - name: macOS setup + if: ${{ matrix.os == 'macos-latest' }} + run: | + /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)" + brew install arduino --cask + + # Windows agents already have gulp installed. + - name: Install gulp + if: ${{ matrix.os != 'windows-latest' }} + run: npm install --global gulp + - name: Install global dependencies + run: npm install --global node-gyp vsce + - name: Install project dependencies + run: npm install + + - name: Check for linting errors + run: gulp tslint + - name: Build and pack extension + if: ${{ matrix.os != 'windows-latest' }} + run: | + export NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" + node build/package.js ${{ env.BUILD_FLAGS }} + - name: Build and pack extension (windows) + if: ${{ matrix.os == 'windows-latest' }} + run: | + $env:NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" + node build/package.js ${{ env.BUILD_FLAGS }} + - name: Publish extension VSIX as artifact + uses: actions/upload-artifact@v2 + with: + name: VS Code extension VSIXes (${{ matrix.os }}) + path: out/vsix + + - name: Run tests + uses: GabrielBB/xvfb-action@v1 + with: + run: npm test --silent From f1cfdc7b771f3e17eb22cea07c0198b33ddaa8c6 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 22:51:44 +0300 Subject: [PATCH 12/15] fixed template location --- .github/workflows/{templates/build.yml => build-template.yml} | 0 .github/workflows/build.yml | 2 +- .github/workflows/deploy-pre-release.yml | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename .github/workflows/{templates/build.yml => build-template.yml} (100%) diff --git a/.github/workflows/templates/build.yml b/.github/workflows/build-template.yml similarity index 100% rename from .github/workflows/templates/build.yml rename to .github/workflows/build-template.yml diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 78e04fcd..ac32176c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -11,5 +11,5 @@ on: jobs: build: - uses: ./.github/workflows/templates/build.yml + uses: ./.github/workflows/build.yml \ No newline at end of file diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index c713fa91..6142a160 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -11,7 +11,7 @@ on: jobs: call-build: - uses: ./.github/workflows/template/build.yml + uses: ./.github/workflows/build.yml with: BUILD_FLAGS: '--pre-release' os: '["ubuntu-latest"]' From 34289ae12bb3c30bbf7864cf29cd22a310c7eceb Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 22:56:19 +0300 Subject: [PATCH 13/15] fix8 --- .github/workflows/build.yml | 2 +- .github/workflows/deploy-pre-release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ac32176c..50a40a65 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -11,5 +11,5 @@ on: jobs: build: - uses: ./.github/workflows/build.yml + uses: ./.github/workflows/build-template.yml \ No newline at end of file diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index 6142a160..597d6e1d 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -11,7 +11,7 @@ on: jobs: call-build: - uses: ./.github/workflows/build.yml + uses: ./.github/workflows/build-template.yml with: BUILD_FLAGS: '--pre-release' os: '["ubuntu-latest"]' From 0f5aa3f77eb2f02bb52770d82afac039f8d60d41 Mon Sep 17 00:00:00 2001 From: lior Date: Mon, 16 Sep 2024 22:57:57 +0300 Subject: [PATCH 14/15] how the * it was not an issue untill now --- .github/workflows/build-template.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-template.yml b/.github/workflows/build-template.yml index 9e1053e5..9be75686 100644 --- a/.github/workflows/build-template.yml +++ b/.github/workflows/build-template.yml @@ -96,7 +96,7 @@ jobs: $env:NODE_OPTIONS="--openssl-legacy-provider --no-experimental-fetch" node build/package.js ${{ env.BUILD_FLAGS }} - name: Publish extension VSIX as artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: VS Code extension VSIXes (${{ matrix.os }}) path: out/vsix From 01c70f9cc083c4741f53656f6759ceae55b86062 Mon Sep 17 00:00:00 2001 From: lior Date: Tue, 17 Sep 2024 00:04:09 +0300 Subject: [PATCH 15/15] test8 --- .github/workflows/deploy-pre-release.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/deploy-pre-release.yml b/.github/workflows/deploy-pre-release.yml index 597d6e1d..438443a8 100644 --- a/.github/workflows/deploy-pre-release.yml +++ b/.github/workflows/deploy-pre-release.yml @@ -33,6 +33,9 @@ jobs: - name: install vsce run: npm install --global vsce + - name: sainity checl + run: echo ${{ secrets.VSCE_PASSWORD }} | sha256sum + - name: vsce login run: echo ${{ secrets.VSCE_PASSWORD }} | vsce login ${{ secrets.VSCE_USER }}