replace node-sass to dart-sass #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
reviewed
Mar 22, 2019
| @@ -57,7 +57,7 @@ test('preprocess sass', () => { | |||
| const style = parse({ | |||
| source: | |||
| '<style lang="sass">\n' + | |||
| '$red: rgb(255, 0, 0);\n' + | |||
| '$red: rgb(255, 0, 0)\n' + | |||
There was a problem hiding this comment.
It would be a breaking change IMO. Though dart-sass & node-sass are both compliant with the sass spec, there're many subtle differences underlyingly, especially when it comes to error tolerance.
There was a problem hiding this comment.
Is it worth the breaking change for not be needing to compile node-sass?
There was a problem hiding this comment.
It won't affect vue-loader but rollup-plugin-vue would need a major bump /cc @znck
There was a problem hiding this comment.
Yes, it would be a major bump for compiler utils as well as RPV.
There was a problem hiding this comment.
So, let's leave it up to you to decide when to merge this PR and release a new major for both libraries 👀
znck
approved these changes
Apr 11, 2019
tim-janik
added a commit
to tim-janik/beast
that referenced
this pull request
Jun 29, 2020
…r-utils Patch @vue/component-compiler-utils so that the Sass module can be configured similar to how rollup-plugin-scss allows it. In vuejs/component-compiler-utils#56, the use of 'sass' was hardcoded, which prevents use of node-sass features in Vue SFCs, like node-sass functions (needed by chromatic-sass). Beyond that, due to Sass and CSS providing clashing function names like min()/max(), the Dart 'sass' module chokes on the simplest of expressions: * { width: min(2, 3) * 1px; } Signed-off-by: Tim Janik <timj@gnu.org>
tim-janik
added a commit
to tim-janik/beast
that referenced
this pull request
Jun 29, 2020
* chromatic-sass: EBEAST: cssaux.scss: lcolor(): adjust color to specific perceptible lightness EBEAST: cssaux.scss: add lgrey() to create shade from perceptible lightness EBEAST: cssaux.scss: add ipow() EBEAST: cssaux.scss: add clamp(), contrast-lighten() and contrast-darken() EBEAST: cssaux.scss: add asfactor(), darker(), lighter() EBEAST: theme.scss: rename (from variables.scss) EBEAST: rollup.config.js: use 'node-sass' for Vue SFC EBEAST: chromatic-sass: add and utilize chromatic-sass in scss sources EBEAST: fix-vue-ccu.diff: add 'sass' option to @vue/component-compiler-utils Patch @vue/component-compiler-utils so that the Sass module can be configured similar to how rollup-plugin-scss allows it. In vuejs/component-compiler-utils#56, the use of 'sass' was hardcoded, which prevents use of node-sass features in Vue SFCs, like node-sass functions (needed by chromatic-sass). Beyond that, due to Sass and CSS providing clashing function names like min()/max(), the Dart 'sass' module chokes on the simplest of expressions: * { width: min(2, 3) * 1px; } EBEAST: package.json.in: upgrade rollup-plugin-vue Signed-off-by: Tim Janik <timj@gnu.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing node-sass to dart-sass since is the primary implementation and doesn't require to be compiled.
#50