Skip to content

fix: add parse options to cache key #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2020
Merged

fix: add parse options to cache key #78

merged 2 commits into from
Jan 21, 2020

Conversation

meteorlxy
Copy link
Member

Currently, if we call parse() on a same file with different compilerParseOptions, it will return the same cached result, which is supposed to be differed:

const a = parse({
  source: 'aaa',
  filename: 'bbb',
  compilerParseOptions: { pad: 'line' },
})

// `b` is unexpectly cached, which leads to a wrong result
const b = parse({
  source: 'aaa',
  filename: 'bbb',
  compilerParseOptions: { pad: 'space' },
})

yyx990803
yyx990803 requested changes Jan 20, 2020
View reviewed changes
@meteorlxy
Copy link
Member Author

BTW, does vuejs accept more core members?

Currently I'm one of the collaborators of VuePress. It has been more than three months since VuePress' last release, but the whole collaborator team does not have access to publish VuePress npm package.

I'm willing to help maintain VuePress if our current team leader ulivz is busy now.

@yyx990803 yyx990803 merged commit f7b1f87 into vuejs:master Jan 21, 2020
@yyx990803
Copy link
Member

@meteorlxy that would be great. ^ @ulivz what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorlxy @yyx990803