feat: add rolldown-vite features
#760
Open
+104
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
approved these changes
Jun 10, 2025
haoqunjiang
requested changes
Jun 12, 2025
| @@ -76,6 +77,20 @@ const FEATURE_OPTIONS = [ | |||
| value: 'prettier', | |||
| label: language.needsPrettier.message, | |||
| }, | |||
| { | |||
| value: 'experimental-features', | |||
| label: language.needsExperimental.message, | |||
There was a problem hiding this comment.
I prefer not to make "Enable experimental features" itself a feature selection.
Just looking at this description will not provide users with enough knowledge about the possible experimental features to make an informed decision.
So, let's just ask all the users about the experimental features. As long as the default is none, it won't disrupt the workflow.
There was a problem hiding this comment.
Does oxlint keep the original logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #756