From 0f8c4e8838700404a8b90898152c5f3d61b8ddee Mon Sep 17 00:00:00 2001 From: opowell Date: Wed, 19 Aug 2020 17:34:24 +0200 Subject: [PATCH 1/5] docs: fix typo in README.md (#1242) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 67aba0e80..07ca6e27b 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,7 @@ This is only necessary when you want to build the extension yourself from source 4. Open the Chrome extension page (currently under Menu > More Tools > Extensions) 5. Check "developer mode" on the top-right corner 6. Click the "load unpacked" button on the left, and choose the folder: `vue-devtools/packages/shell-chrome/` -7. Alternatilvely to step 3, you can also use `yarn dev:chrome` to build & watch the unpacked extension +7. Alternatively to step 3, you can also use `yarn dev:chrome` to build & watch the unpacked extension ### Development From 6d8fee4d058716fe72825c9ae22cf831ef8f5172 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Here=C3=B1=C3=BA?= Date: Wed, 19 Aug 2020 12:36:22 -0300 Subject: [PATCH 2/5] docs: fixed typo and enhance readability in README (#1162) * Fixed typo on line 38 * semantic proposal on line 27 * plus minor formatting proposals * docs: improve phrasing Co-authored-by: Ben Hong --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 07ca6e27b..34f949660 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ To enable this feature, follow [this guide](./docs/open-in-editor.md). ### Manual Installation -This is only necessary when you want to build the extension yourself from source to get not-yet-released features. +This is only necessary when you want to build the extension with the source repo to get not-yet-released features. **Make sure you are using Node 6+ and NPM 3+** @@ -32,7 +32,7 @@ This is only necessary when you want to build the extension yourself from source 2. `cd vue-devtools` the newly created folder 2. run `yarn install` 3. then run `yarn run build` -4. Open the Chrome extension page (currently under Menu > More Tools > Extensions) +4. Open the Chrome extension page (currently under `Menu` > `More Tools` > `Extensions`) 5. Check "developer mode" on the top-right corner 6. Click the "load unpacked" button on the left, and choose the folder: `vue-devtools/packages/shell-chrome/` 7. Alternatively to step 3, you can also use `yarn dev:chrome` to build & watch the unpacked extension From 900f2be6f256f6ce4ffce9a8f3ed62fa17099c7a Mon Sep 17 00:00:00 2001 From: Guillaume Chau Date: Fri, 29 Jan 2021 12:02:48 +0100 Subject: [PATCH 3/5] fix(security): toast vulnerable to XSS attack, closes #1353 --- .../shell-chrome/src/devtools-background.js | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/packages/shell-chrome/src/devtools-background.js b/packages/shell-chrome/src/devtools-background.js index 17b87ec98..4437dadc4 100644 --- a/packages/shell-chrome/src/devtools-background.js +++ b/packages/shell-chrome/src/devtools-background.js @@ -46,7 +46,7 @@ chrome.runtime.onMessage.addListener(request => { if (request === 'vue-panel-load') { onPanelLoad() } else if (request.vueToast) { - toast(request.vueToast.message, request.vueToast.type) + toast(request.vueToast) } else if (request.vueContextMenu) { onContextMenu(request.vueContextMenu) } @@ -65,10 +65,10 @@ function onContextMenu ({ id }) { if (typeof res !== 'undefined' && res) { panelAction(() => { chrome.runtime.sendMessage('vue-get-context-menu-target') - }, 'Open Vue devtools to see component details') + }, 'open-devtools') } else { pendingAction = null - toast('No Vue component was found', 'warn') + toast('component-not-found') } }) } @@ -113,7 +113,16 @@ function onPanelHidden () { // Toasts -function toast (message, type = 'normal') { +const toastMessages = { + 'open-devtools': { message: 'Open Vue devtools to see component details', type: 'normal' }, + 'component-not-found': { message: 'No Vue component was found', type: 'warn' } +} + +function toast (id) { + if (!Object.keys().includes(id)) return + + const { message, type } = toastMessages[id] + const src = `(function() { __VUE_DEVTOOLS_TOAST__(\`${message}\`, '${type}'); })()` From 7075a1273b720417379e36a0726546b90b38c825 Mon Sep 17 00:00:00 2001 From: Guillaume Chau Date: Fri, 29 Jan 2021 12:14:43 +0100 Subject: [PATCH 4/5] chore: v5.3.4 --- package.json | 2 +- packages/shell-chrome/manifest.json | 4 ++-- packages/shell-electron/package.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 220acb779..37b45e619 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "vue-devtools", - "version": "5.3.3", + "version": "5.3.4", "description": "devtools for Vue.js!", "private": true, "workspaces": [ diff --git a/packages/shell-chrome/manifest.json b/packages/shell-chrome/manifest.json index 905bee0c1..3237aaa5e 100644 --- a/packages/shell-chrome/manifest.json +++ b/packages/shell-chrome/manifest.json @@ -1,7 +1,7 @@ { "name": "Vue.js devtools", - "version": "5.3.3", - "version_name": "5.3.3", + "version": "5.3.4", + "version_name": "5.3.4", "description": "Chrome and Firefox DevTools extension for debugging Vue.js applications.", "manifest_version": 2, "icons": { diff --git a/packages/shell-electron/package.json b/packages/shell-electron/package.json index 74b463f9a..8dc74457a 100644 --- a/packages/shell-electron/package.json +++ b/packages/shell-electron/package.json @@ -1,6 +1,6 @@ { "name": "@vue/devtools", - "version": "5.3.3", + "version": "5.3.4", "description": "StandAlone vue-devtools", "repository": { "url": "https://github.com/vuejs/vue-devtools.git", From 80924e596eb8cd018ed1bc5a4b0c5cd734f071ed Mon Sep 17 00:00:00 2001 From: PwnFunction Date: Mon, 1 Feb 2021 05:14:33 +0530 Subject: [PATCH 5/5] fix: missing argument for `Object.keys` (#1356) Recent fix fa17699aba2bd9c76dd86d63143b9a28d1d3b05f has a missing argument for `Object.Keys()`. --- packages/shell-chrome/src/devtools-background.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shell-chrome/src/devtools-background.js b/packages/shell-chrome/src/devtools-background.js index 4437dadc4..ca7aafb4c 100644 --- a/packages/shell-chrome/src/devtools-background.js +++ b/packages/shell-chrome/src/devtools-background.js @@ -119,7 +119,7 @@ const toastMessages = { } function toast (id) { - if (!Object.keys().includes(id)) return + if (!Object.keys(toastMessages).includes(id)) return const { message, type } = toastMessages[id]