From 2312a3aceada22de09dfa1428e61ffda93404cf9 Mon Sep 17 00:00:00 2001 From: Joshua Sosso Date: Mon, 5 Apr 2021 17:45:06 -0500 Subject: [PATCH 1/3] add missing data to "shell-electron/types" --- packages/shell-electron/package.json | 3 ++- packages/shell-electron/types/index.d.ts | 16 +++++++++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/packages/shell-electron/package.json b/packages/shell-electron/package.json index 8dc74457a..5ce697f17 100644 --- a/packages/shell-electron/package.json +++ b/packages/shell-electron/package.json @@ -34,7 +34,8 @@ "@vue-devtools/app-frontend": "^0.0.0", "@vue-devtools/build-tools": "^0.0.0", "@vue-devtools/shared-utils": "^0.0.0", + "vue": "^2.6.12", "webpack": "^4.19.0", "webpack-cli": "^3.1.0" } -} \ No newline at end of file +} diff --git a/packages/shell-electron/types/index.d.ts b/packages/shell-electron/types/index.d.ts index c9b28d466..f7eab533b 100644 --- a/packages/shell-electron/types/index.d.ts +++ b/packages/shell-electron/types/index.d.ts @@ -1 +1,15 @@ -export function connect(host?: string, port?: number|string): void +import type Vue from "vue"; + +interface ConnectOptions { + io?: Function; + showToast?: Function; + app?: Vue | Vue[]; +} + +export function connect( + host?: string, + port?: number | string, + options: ConnectOptions +): void; + +export function init(vue: Vue | Vue[]): void; From a483e83f6ed7be4f5e4e5d190f3bb3aa85f44ff3 Mon Sep 17 00:00:00 2001 From: Joshua Sosso Date: Mon, 5 Apr 2021 17:52:46 -0500 Subject: [PATCH 2/3] make options optional --- packages/shell-electron/types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shell-electron/types/index.d.ts b/packages/shell-electron/types/index.d.ts index f7eab533b..e807069df 100644 --- a/packages/shell-electron/types/index.d.ts +++ b/packages/shell-electron/types/index.d.ts @@ -9,7 +9,7 @@ interface ConnectOptions { export function connect( host?: string, port?: number | string, - options: ConnectOptions + options?: ConnectOptions ): void; export function init(vue: Vue | Vue[]): void; From 3860a50ecb3b7734b7177c1c5f8e33bf85518fce Mon Sep 17 00:00:00 2001 From: Joshua Sosso Date: Mon, 5 Apr 2021 18:24:29 -0500 Subject: [PATCH 3/3] fix typings --- packages/shell-electron/types/index.d.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/shell-electron/types/index.d.ts b/packages/shell-electron/types/index.d.ts index e807069df..b0113b795 100644 --- a/packages/shell-electron/types/index.d.ts +++ b/packages/shell-electron/types/index.d.ts @@ -1,9 +1,9 @@ -import type Vue from "vue"; +import type { VueConstructor } from "vue"; interface ConnectOptions { io?: Function; showToast?: Function; - app?: Vue | Vue[]; + app?: VueConstructor | VueConstructor[]; } export function connect( @@ -12,4 +12,4 @@ export function connect( options?: ConnectOptions ): void; -export function init(vue: Vue | Vue[]): void; +export function init(vue: VueConstructor | VueConstructor[]): void;